Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listen later ui added #96

Merged
merged 75 commits into from
May 15, 2020
Merged

Listen later ui added #96

merged 75 commits into from
May 15, 2020

Conversation

pravinyo
Copy link
Owner

Following issues will be closed :
resolved #95 ,
resolved #94 ,
resolved #54 ,
resolved #64 ,
resolved #79 ,
resolved #56

Following changes has been done:

  • Created Listen Later screen
  • Bug fixed for book details screen
  • test fixed
  • event bus added for user action event
  • integrated with nav drawer
  • book details UI improved
  • download location setting added

@pravinyo
common dependency inject is added
67da551
@pravinyo
module unloading called on destroy
5aba10a
@pravinyo
unload Module defined
ecd5447
@pravinyo
base Module inject defined for common dependency
a7f1a1d
@pravinyo
module unloading called on destroy
d78e360
@pravinyo
license activity theme ADDED
de1f30a
@pravinyo
license activity theme style
6178de2
@pravinyo
user action event store added for UI actions
4b97c63
@pravinyo
Ui event moved to UserActionEvent
5e0ba9e
@pravinyo
user action event store added
2b16b50
@pravinyo
dependency for User action store added
03a0e03
@pravinyo
UI action event is sent to user action store
44b9bce
@pravinyo
dependency for User action store added
a874a49
@pravinyo
unused file removed
27e102b
@pravinyo
oss library dependency added
27bdf1f
@pravinyo
oss library dependency added
84bd25e
@pravinyo
oss classpath dependency added
080c452
@pravinyo
additional keys added
8cacd90
@pravinyo
color changed
136af75
@pravinyo
about and miscellaneous section added
159689c
@pravinyo
string resources added for new about and miscellaneous
88847a3
@pravinyo
preferences added for about and miscellaneous
61373cf
@pravinyo
listen later module created
7b52b08
@pravinyo
listen later module added to dependency
7a0158d
@pravinyo
listen later module dependency added
73a0ea5
@pravinyo
Listen later fragment added in navigation graph
31f7155
@pravinyo
nav item click implemented for listen later
9f72d69
@pravinyo
database and koin viewmodel dependency added
e6683ee
@pravinyo
initial commit for listen later fragment
691a574
@pravinyo
listen later viewmodel added
475ab65
@pravinyo pravinyo added bug Something isn't working enhancement New feature or request feature Feature related issue app issues related to app working labels May 15, 2020
@pravinyo pravinyo added this to the enhancement-phase-1 milestone May 15, 2020
@pravinyo pravinyo self-assigned this May 15, 2020
@github-actions github-actions bot added the library issues related to core library label May 15, 2020
@pravinyo pravinyo merged commit 21137d5 into development May 15, 2020
@pravinyo pravinyo added this to Done in AudioBook Project via automation May 15, 2020
@pravinyo pravinyo deleted the listen_later_ui branch May 15, 2020 09:31
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pravinyo pravinyo

Labels
app issues related to app working bug Something isn't working enhancement New feature or request feature Feature related issue library issues related to core library
Projects
AudioBook Project
  
Done
Milestone
enhancement-phase-1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pravinyo