Merge pull request #24 from LilSpazJoekp/gallery_url

Add support for gallery urls

CHANGES.rst

@@ -7,6 +7,7 @@ Unreleased
 **Added**
 
 * Ability to submit image galleries with :meth:`.submit_gallery`.
+* Ability to pass a gallery url to :meth:`.Reddit.submission`.
 * Ability to specify modmail mute duration.
 
 **Changed**

asyncpraw/models/reddit/submission.py

@@ -423,17 +423,20 @@ def id_from_url(url: str) -> str:
             * https://redd.it/2gmzqe
             * https://reddit.com/comments/2gmzqe/
             * https://www.reddit.com/r/redditdev/comments/2gmzqe/praw_https/
+            * https://www.reddit.com/gallery/2gmzqe
 
         :raises: :class:`.InvalidURL` if URL is not a valid submission URL.
 
         """
         parts = RedditBase._url_parts(url)
-        if "comments" not in parts:
+        if "comments" not in parts and "gallery" not in parts:
             submission_id = parts[-1]
             if "r" in parts:
                 raise InvalidURL(
                     url, message="Invalid URL (subreddit, not submission): {}"
                 )
+        elif "gallery" in parts:
+            submission_id = parts[parts.index("gallery") + 1]
         else:
             submission_id = parts[parts.index("comments") + 1]
 

tests/unit/models/reddit/test_submission.py

@@ -66,8 +66,8 @@ def test_id_from_url(self):
             "https://redd.it/2gmzqe",
             "https://redd.it/2gmzqe/",
             "http://reddit.com/comments/2gmzqe",
-            "https://www.reddit.com/r/redditdev/comments/2gmzqe/"
-            "praw_https_enabled_praw_testing_needed/",
+            "https://www.reddit.com/r/redditdev/comments/2gmzqe/praw_https_enabled_praw_testing_needed/",
+            "https://www.reddit.com/gallery/2gmzqe",
         ]
         for url in urls:
             assert Submission.id_from_url(url) == "2gmzqe", url