Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of listing methods in subreddit classes #129

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

Lordshinjo
Copy link
Contributor

This is an asyncpraw only change, fixing the return type of functions returning a ListingGenerator from Iterator to AsyncIterator in subreddit.py.

Typing was previously added as-is in #76 without adjustment for the different implementation of ListingGenerator between praw and asyncpraw.

@LilSpazJoekp
Copy link
Member

Thanks for catching this!

Would you mind adding yourself to the Documentation Contributors section in the AUTHORS.rst file?

@Lordshinjo
Copy link
Contributor Author

Would you mind adding yourself to the Documentation Contributors section in the AUTHORS.rst file?

Sure!

@LilSpazJoekp LilSpazJoekp merged commit dcd0745 into praw-dev:master Aug 25, 2021
@LilSpazJoekp
Copy link
Member

Thanks for catching that! 🎇

@Lordshinjo Lordshinjo deleted the subreddit-asynciterator branch August 25, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants