Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply async to functions #2

Merged
merged 26 commits into from
Jul 6, 2020
Merged

Apply async to functions #2

merged 26 commits into from
Jul 6, 2020

Conversation

LilSpazJoekp
Copy link
Member

@LilSpazJoekp LilSpazJoekp commented Jun 30, 2020

  • config.py
    • class: _NotSet
      • __bool__()
      • __str__()
    • class: Config
      • _config_boolean()
      • _load_config()
      • short_url()
      • __init__()
      • _fetch()
      • _fetch_default()
      • _fetch_or_not_set()
      • _initialize_attributes()
  • objector.py
    • class: Objector
      • parse_error()
      • check_error()
      • __init__()
      • _objectify_dict()
      • objectify()
  • __init__.py
  • exceptions.py
    • class: PRAWException
    • class: RedditErrorItem
      • error_message()
      • __init__()
      • __eq__()
      • __repr__()
      • __str__()
    • class: APIException
      • parse_exception_list()
      • error_type()
      • message()
      • field()
      • _get_old_attr()
      • __init__()
    • class: RedditAPIException
    • class: ClientException
    • class: DuplicateReplaceException
      • __init__()
    • class: InvalidFlairTemplateID
      • __init__()
    • class: InvalidImplicitAuth
      • __init__()
    • class: InvalidURL
      • __init__()
    • class: MissingRequiredAttributeException
    • class: TooLargeMediaException
      • __init__()
    • class: WebSocketException
      • original_exception()
      • original_exception()
      • original_exception()
      • __init__()
    • class: MediaPostFailed
      • __init__()
  • reddit.py
    • class: Reddit
      • _next_unique()
      • read_only()
      • read_only()
      • validate_on_submit()
      • validate_on_submit()
      • __enter__()
      • __exit__()
      • __init__()
      • _check_for_update()
      • _prepare_objector()
      • _prepare_prawcore()
      • _prepare_trusted_prawcore()
      • _prepare_untrusted_prawcore()
      • domain()
      • info()
      • _handle_rate_limit()
      • comment()
      • get()
      • _objectify_request()
      • delete()
      • patch()
      • post()
      • put()
      • random_subreddit()
      • redditor()
      • request()
      • submission()
  • endpoints.py
  • const.py
  • util/cache.py
    • class: cachedproperty
      • __init__()
      • __get__()
      • __repr__()
  • util/__init__.py
  • util/snake.py
    • camel_to_snake()
    • snake_case_keys()
  • models/redditors.py
    • class: PartialRedditor
    • class: Redditors
      • new()
      • popular()
      • search()
      • stream()
      • partial_redditors()
  • models/auth.py
    • class: Auth
      • limits()
      • implicit()
      • url()
      • authorize()
      • scopes()
  • models/subreddits.py
    • class: Subreddits
      • _to_list()
      • default()
      • gold()
      • new()
      • popular()
      • search()
      • stream()
      • recommended()
      • search_by_name()
      • search_by_topic()
  • models/user.py
    • class: User
      • preferences()
      • __init__()
      • contributor_subreddits()
      • subreddits()
      • blocked()
      • friends()
      • karma()
      • me()
      • multireddits()
  • models/util.py
    • permissions_string()
    • stream_generator()
    • class: BoundedSet
      • __init__()
      • __contains__()
      • add()
    • class: ExponentialCounter
      • __init__()
      • counter()
      • reset()
  • models/preferences.py
    • class: Preferences
      • __init__()
      • __call__()
      • update()
  • models/__init__.py
  • models/mod_action.py
    • class: ModAction
      • mod()
      • mod()
  • models/inbox.py
    • class: Inbox
      • all()
      • comment_replies()
      • mentions()
      • messages()
      • sent()
      • stream()
      • submission_replies()
      • unread()
      • collapse()
      • mark_read()
      • mark_unread()
      • message()
      • uncollapse()
  • models/comment_forest.py
    • class: CommentForest
      • __getitem__()
      • __init__()
      • __len__()
      • _insert_comment()
      • _update()
      • _gather_more_comments()
      • __aiter__()
      • list()
      • replace_more()
  • models/front.py
    • class: Front
      • __init__()
      • best()
  • models/trophy.py
    • class: Trophy
      • __init__()
      • __eq__()
      • __str__()
      • __repr__()
  • models/stylesheet.py
    • class: Stylesheet
  • models/helpers.py
    • class: LiveHelper
      • info()
      • __call__()
      • create()
      • now()
    • class: MultiredditHelper
      • __call__()
      • create()
    • class: SubredditHelper
      • __call__()
      • create()
  • models/base.py
    • class: PRAWBase
      • _safely_add_arguments()
      • parse()
      • __init__()
  • models/list/__init__.py
  • models/list/redditor.py
    • class: RedditorList
  • models/list/trophy.py
    • class: TrophyList
  • models/list/base.py
    • class: BaseList
      • __init__()
      • __contains__()
      • __getitem__()
      • __iter__()
      • __len__()
      • __str__()
      • __aiter__()
  • models/reddit/comment.py
    • class: Comment
      • id_from_url()
      • _kind()
      • is_root()
      • mod()
      • replies()
      • submission()
      • submission()
      • __init__()
      • __setattr__()
      • _fetch_info()
      • _extract_submission_id()
      • _fetch_data()
      • _fetch()
      • parent()
      • refresh()
    • class: CommentModeration
      • __init__()
      • show()
  • models/reddit/emoji.py
    • class: Emoji
      • __eq__()
      • __hash__()
      • __init__()
      • _fetch()
      • delete()
      • update()
    • class: SubredditEmoji
      • __init__()
      • get_emoji()
      • __aiter__()
      • add()
  • models/reddit/multi.py
    • class: Multireddit
      • sluggify()
      • stream()
      • __init__()
      • _ensure_author_fetched()
      • _fetch_info()
      • _fetch_data()
      • _fetch()
      • add()
      • copy()
      • delete()
      • remove()
      • update()
  • models/reddit/submission.py
    • class: SubmissionFlair
      • __init__()
      • choices()
      • select()
    • class: SubmissionModeration
      • __init__()
      • contest_mode()
      • flair()
      • nsfw()
      • set_original_content()
      • sfw()
      • spoiler()
      • sticky()
      • suggested_sort()
      • unset_original_content()
      • unspoiler()
    • class: Submission
      • id_from_url()
      • _kind()
      • flair()
      • mod()
      • shortlink()
      • __init__()
      • __setattr__()
      • _chunk()
      • _fetch_info()
      • comments()
      • _fetch_data()
      • _fetch()
      • mark_visited()
      • hide()
      • unhide()
      • crosspost()
  • models/reddit/__init__.py
  • models/reddit/rules.py
    • class: Rule
      • mod()
      • __init__()
      • __getattribute__()
      • _fetch()
    • class: SubredditRules
      • mod()
      • __call__()
      • __getitem__()
      • __init__()
      • __iter__()
      • _rule_list()
    • class: RuleModeration
      • __init__()
      • delete()
      • update()
    • class: SubredditRulesModeration
      • __init__()
      • add()
      • reorder()
  • models/reddit/message.py
    • class: Message
      • parse()
      • _kind()
      • __init__()
      • delete()
    • class: SubredditMessage
      • mute()
      • unmute()
  • models/reddit/redditor.py
    • class: Redditor
      • from_data()
      • stream()
      • _kind()
      • _path()
      • __init__()
      • _fetch_username()
      • _fetch_info()
      • _fetch_data()
      • _fetch()
      • _friend()
      • block()
      • friend()
      • friend_info()
      • gild()
      • moderated()
      • multireddits()
      • trophies()
      • unblock()
      • unfriend()
    • class: RedditorStream
      • __init__()
      • comments()
      • submissions()
  • models/reddit/wikipage.py
    • class: WikiPageModeration
      • __init__()
      • add()
      • remove()
      • settings()
      • update()
    • class: WikiPage
      • mod()
      • __init__()
      • __repr__()
      • __str__()
      • _fetch_info()
      • revisions()
      • _revision_generator()
      • _fetch_data()
      • _fetch()
      • edit()
      • revision()
  • models/reddit/widgets.py
    • class: Button
    • class: CalendarConfiguration
    • class: Hover
    • class: Image
    • class: ImageData
    • class: MenuLink
    • class: Styles
    • class: Submenu
    • class: SubredditWidgets
      • mod()
      • __getattr__()
      • __init__()
      • __repr__()
      • id_card()
      • items()
      • moderators_widget()
      • sidebar()
      • topbar()
      • refresh()
      • _fetch()
    • class: SubredditWidgetsModeration
      • __init__()
      • _create_widget()
      • add_button_widget()
      • add_calendar()
      • add_community_list()
      • add_custom_widget()
      • add_image_widget()
      • add_menu()
      • add_post_flair_widget()
      • add_text_area()
      • reorder()
      • upload_image()
    • class: Widget
      • mod()
      • __eq__()
      • __init__()
    • class: ButtonWidget
    • class: Calendar
    • class: CommunityList
    • class: CustomWidget
      • __init__()
    • class: IDCard
    • class: ImageWidget
    • class: Menu
    • class: ModeratorsWidget
      • __init__()
    • class: PostFlairWidget
    • class: RulesWidget
      • __init__()
    • class: TextArea
    • class: WidgetEncoder
      • default()
    • class: WidgetModeration
      • __init__()
      • delete()
      • update()
  • models/reddit/subreddit.py
    • class: Subreddit
      • _subreddit_list()
      • _kind()
      • banned()
      • collections()
      • contributor()
      • emoji()
      • filters()
      • flair()
      • mod()
      • moderator()
      • modmail()
      • muted()
      • quaran()
      • rules()
      • stream()
      • stylesheet()
      • widgets()
      • wiki()
      • __init__()
      • _fetch_info()
      • _parse_xml_response()
      • search()
      • _create_or_update()
      • _fetch_data()
      • _fetch()
      • _submit_media()
      • _upload_media()
      • post_requirements()
      • random()
      • sticky()
      • submit()
      • submit_image()
      • submit_poll()
      • submit_video()
      • subscribe()
      • traffic()
      • unsubscribe()
    • class: SubredditFilters
      • __init__()
      • __aiter__()
      • add()
      • remove()
    • class: SubredditFlair
      • link_templates()
      • templates()
      • __init__()
      • __call__()
      • configure()
      • delete()
      • delete_all()
      • set()
      • update()
    • class: SubredditFlairTemplates
      • flair_type()
      • __init__()
      • __aiter__()
      • _add()
      • _clear()
      • delete()
      • update()
    • class: SubredditRedditorFlairTemplates
      • __aiter__()
      • add()
      • clear()
    • class: SubredditLinkFlairTemplates
      • __aiter__()
      • add()
      • clear()
    • class: SubredditModeration
      • _handle_only()
      • __init__()
      • edited()
      • inbox()
      • log()
      • modqueue()
      • stream()
      • removal_reasons()
      • reports()
      • spam()
      • unmoderated()
      • unread()
      • accept_invite()
      • settings()
      • update()
    • class: SubredditModerationStream
      • __init__()
      • edited()
      • log()
      • modmail_conversations()
      • modqueue()
      • reports()
      • spam()
      • unmoderated()
      • unread()
    • class: SubredditQuarantine
      • __init__()
      • opt_in()
      • opt_out()
    • class: SubredditRelationship
      • __call__()
      • __init__()
      • add()
      • remove()
    • class: ContributorRelationship
      • leave()
    • class: ModeratorRelationship
      • _handle_permissions()
      • __call__()
      • add()
      • invite()
      • leave()
      • remove_invite()
      • update()
      • update_invite()
    • class: Modmail
      • __init__()
      • _build_subreddit_list()
      • __call__()
      • bulk_read()
      • conversations()
      • create()
      • subreddits()
      • unread_count()
    • class: SubredditStream
      • __init__()
      • comments()
      • submissions()
    • class: SubredditStylesheet
      • __init__()
      • __call__()
      • _update_structured_styles()
      • _upload_image()
      • _upload_style_asset()
      • delete_banner()
      • delete_banner_additional_image()
      • delete_banner_hover_image()
      • delete_header()
      • delete_image()
      • delete_mobile_header()
      • delete_mobile_icon()
      • update()
      • upload()
      • upload_banner()
      • upload_banner_additional_image()
      • upload_banner_hover_image()
      • upload_header()
      • upload_mobile_header()
      • upload_mobile_icon()
    • class: SubredditWiki
      • __init__()
      • revisions()
      • get_page()
      • __aiter__()
      • create()
  • models/reddit/more.py
    • class: MoreComments
      • __init__()
      • __eq__()
      • __lt__()
      • __repr__()
      • _continue_comments()
      • _load_comment()
      • comments()
  • models/reddit/collections.py
    • class: Collection
      • mod()
      • __init__()
      • __iter__()
      • __len__()
      • __setattr__()
      • _fetch_info()
      • subreddit()
      • _fetch_data()
      • _fetch()
      • follow()
      • unfollow()
    • class: CollectionModeration
      • __init__()
      • _post_fullname()
      • add_post()
      • delete()
      • remove_post()
      • reorder()
      • update_description()
      • update_title()
    • class: SubredditCollections
      • mod()
      • __init__()
      • __call__()
      • __aiter__()
    • class: SubredditCollectionsModeration
      • __init__()
      • create()
  • models/reddit/modmail.py
    • class: ModmailConversation
      • _convert_conversation_objects()
      • _convert_user_summary()
      • parse()
      • __init__()
      • _build_conversation_list()
      • _fetch_info()
      • _fetch_data()
      • _fetch()
      • archive()
      • highlight()
      • mute()
      • read()
      • reply()
      • unarchive()
      • unhighlight()
      • unmute()
      • unread()
    • class: ModmailObject
      • __setattr__()
    • class: ModmailAction
    • class: ModmailMessage
  • models/reddit/live.py
    • class: LiveContributorRelationship
      • _handle_permissions()
      • __call__()
      • __init__()
      • accept_invite()
      • invite()
      • leave()
      • remove()
      • remove_invite()
      • update()
      • update_invite()
    • class: LiveThread
      • contrib()
      • contributor()
      • stream()
      • __eq__()
      • __hash__()
      • __init__()
      • _fetch_info()
      • discussions()
      • get_update()
      • _fetch_data()
      • _fetch()
      • report()
      • updates()
    • class: LiveThreadContribution
      • __init__()
      • add()
      • close()
      • update()
    • class: LiveThreadStream
      • __init__()
      • updates()
    • class: LiveUpdate
      • contrib()
      • thread()
      • __init__()
      • __setattr__()
      • _fetch()
    • class: LiveUpdateContribution
      • __init__()
      • remove()
      • strike()
  • models/reddit/poll.py
    • class: PollOption
      • __repr__()
      • __str__()
    • class: PollData
      • user_selection()
      • __setattr__()
      • option()
  • models/reddit/removal_reasons.py
    • class: RemovalReason
      • _warn_reason_id()
      • __eq__()
      • __hash__()
      • __init__()
      • _fetch()
      • delete()
      • update()
    • class: SubredditRemovalReasons
      • __init__()
      • get_reason()
      • __aiter__()
      • _removal_reason_list()
      • add()
  • models/reddit/base.py
    • class: RedditBase
      • _url_parts()
      • __eq__()
      • __getattr__()
      • __hash__()
      • __init__()
      • __repr__()
      • __str__()
      • __ne__()
      • _fetch()
      • _reset_attributes()
      • update()
  • models/reddit/mixins/reportable.py
    • class: ReportableMixin
      • report()
  • models/reddit/mixins/editable.py
    • class: EditableMixin
      • delete()
      • edit()
  • models/reddit/mixins/inboxtoggleable.py
    • class: InboxToggleableMixin
      • disable_inbox_replies()
      • enable_inbox_replies()
  • models/reddit/mixins/replyable.py
    • class: ReplyableMixin
      • reply()
  • models/reddit/mixins/gildable.py
    • class: GildableMixin
      • gild()
  • models/reddit/mixins/__init__.py
    • class: ThingModerationMixin
      • _add_removal_reason()
      • approve()
      • distinguish()
      • ignore_reports()
      • lock()
      • remove()
      • send_removal_message()
      • undistinguish()
      • unignore_reports()
      • unlock()
    • class: UserContentMixin
  • models/reddit/mixins/fullname.py
    • class: FullnameMixin
      • fullname()
  • models/reddit/mixins/votable.py
    • class: VotableMixin
      • _vote()
      • clear_vote()
      • downvote()
      • upvote()
  • models/reddit/mixins/inboxable.py
    • class: InboxableMixin
      • block()
      • collapse()
      • mark_read()
      • mark_unread()
      • uncollapse()
  • models/reddit/mixins/messageable.py
    • class: MessageableMixin
      • message()
  • models/reddit/mixins/savable.py
    • class: SavableMixin
      • save()
      • unsave()
  • models/listing/domain.py
    • class: DomainListing
      • __init__()
  • models/listing/__init__.py
  • models/listing/listing.py
    • class: Listing
      • __len__()
      • __getitem__()
      • __setattr__()
    • class: FlairListing
      • after()
  • models/listing/generator.py
    • class: ListingGenerator
      • __init__()
      • __aiter__()
      • __anext__()
      • _next_batch()
  • models/listing/mixins/rising.py
    • class: RisingListingMixin
      • random_rising()
      • rising()
  • models/listing/mixins/submission.py
    • class: SubmissionListingMixin
      • duplicates()
  • models/listing/mixins/__init__.py
  • models/listing/mixins/redditor.py
    • class: SubListing
      • __init__()
    • class: RedditorListingMixin
      • comments()
      • submissions()
      • downvoted()
      • gildings()
      • hidden()
      • saved()
      • upvoted()
  • models/listing/mixins/gilded.py
    • class: GildedListingMixin
      • gilded()
  • models/listing/mixins/subreddit.py
    • class: CommentHelper
      • _path()
      • __init__()
      • __call__()
    • class: SubredditListingMixin
      • comments()
      • __init__()
  • models/listing/mixins/base.py
    • _prepare()
    • class: BaseListingMixin
      • _validate_time_filter()
      • controversial()
      • hot()
      • new()
      • top()

@LilSpazJoekp LilSpazJoekp added this to In progress in Release asyncpraw via automation Jun 30, 2020
@LilSpazJoekp LilSpazJoekp force-pushed the apply-async branch 2 times, most recently from ed2c51e to ee57bd6 Compare June 30, 2020 05:34
LilSpazJoekp and others added 3 commits June 30, 2020 00:36
Signed-off-by: LilSpazJoekp <15524072+LilSpazJoekp@users.noreply.github.com>
Signed-off-by: LilSpazJoekp <15524072+LilSpazJoekp@users.noreply.github.com>
@LilSpazJoekp
Copy link
Member Author

Continuation of PR #1

@LilSpazJoekp
Copy link
Member Author

Okay this is ready

@LilSpazJoekp LilSpazJoekp marked this pull request as ready for review July 1, 2020 05:43
@LilSpazJoekp LilSpazJoekp moved this from In progress to Review in progress in Release asyncpraw Jul 3, 2020
Copy link
Contributor

@vikramaditya91 vikramaditya91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

The structure looks good to me

CHANGES.rst Outdated Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
asyncpraw/models/util.py Show resolved Hide resolved
asyncpraw/models/user.py Show resolved Hide resolved
asyncpraw/models/reddit/widgets.py Show resolved Hide resolved
asyncpraw/models/reddit/subreddit.py Show resolved Hide resolved
asyncpraw/models/reddit/collections.py Outdated Show resolved Hide resolved
- Updated docs outside of doc strings.
- Made few changes to make comment_forest.py work properly.
- Added `.update()` to the `RedditBase` class for the end user to explicitly fetch the object.
@vikramaditya91
Copy link
Contributor

@LilSpazJoekp
minor comments. Looks good to me

Release asyncpraw automation moved this from Review in progress to Reviewer approved Jul 6, 2020
Copy link
Contributor

@vikramaditya91 vikramaditya91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Looks good to me

@LilSpazJoekp LilSpazJoekp merged commit 93a0401 into master Jul 6, 2020
Release asyncpraw automation moved this from Reviewer approved to Done Jul 6, 2020
@LilSpazJoekp LilSpazJoekp deleted the apply-async branch July 6, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants