Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor typos #2

Merged
merged 7 commits into from Jun 22, 2020
Merged

Fix minor typos #2

merged 7 commits into from Jun 22, 2020

Conversation

LilSpazJoekp
Copy link
Member

@LilSpazJoekp LilSpazJoekp commented Jun 22, 2020 •
edited

Fixes minor corrections that @PythonCoderAS suggested.

@coveralls
Copy link

coveralls commented Jun 22, 2020 •
edited

Pull Request Test Coverage Report for Build e65e0ab5514f2209a873ae7707b6b473c074dd5f-PR-2

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.051%
Changes Missing Coverage Covered Lines Changed/Added Lines %
asyncprawcore/sessions.py 1 3 33.33%
Totals Coverage Status
Change from base Build 24063ddd487c6c8f49410cdfc2d9634278bd0bb5: 0.0%
Covered Lines: 359
Relevant Lines: 390
💛 - Coveralls

@LilSpazJoekp
Copy link
Member Author

@PythonCoderAS @vikramaditya91 do you two want to take a look at this?

vikramaditya91
vikramaditya91 reviewed Jun 22, 2020
View reviewed changes
AUTHORS.rst Outdated
@@ -1,10 +1,9 @@
asyncprawcore is written and maintained by Bryce Boe and various contributors:
asyncprawcore is written and maintained by Joel Payne and various contributors:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
asyncprawcore is written and maintained by Joel Payne and various contributors:
asyncprawcore is written and maintained by Joel Payne and Vikramaditya Gaonkar and various contributors:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask why was this removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praw has multiple maintainers and does not have this line

vikramaditya91
vikramaditya91 reviewed Jun 22, 2020
View reviewed changes
LICENSE.txt Outdated
@@ -1,3 +1,4 @@
Copyright (c) 2020, Joel Payne
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright (c) 2020, Joel Payne
Copyright (c) 2020, Joel Payne, Vikramaditya Gaonkar

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask why was this removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original copyright goes to bboe since it's mostly his code. I coined and created asyncpraw and asyncprawcore so there for I would hold the copyright for that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since asyncprawcore is a modification on top of the original PRAWcore source code, don’t we still need to keep bboe as one one of the original copyright holders, as the code structure is still the same for the most part? I’m not all too familiar with copyright but I’m pretty sure this would classify as a modification rather than something original.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was suggested by bboe. I was originally going to have Copyright (c) 2020, Joel Payne, Bryce Boe but he suggested to do just my name above his.

vikramaditya91
vikramaditya91 reviewed Jun 22, 2020
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@LilSpazJoekp
Copy link
Member Author

I wanted to check with you first before adding you as a maintainer.

vikramaditya91
vikramaditya91 reviewed Jun 22, 2020
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@PythonCoderAS
Copy link
Contributor

PythonCoderAS commented Jun 22, 2020 •
edited

Can you add me on as maintainer?

This is different than author, https://packaging.python.org/specifications/core-metadata/#maintainer

@LilSpazJoekp
Copy link
Member Author

Can you add me on as maintainer?

Not right now. If you actively help with the project I'd be more willing to.

@PythonCoderAS
Copy link
Contributor

I’ll contribute more in the following days.

@LilSpazJoekp
Copy link
Member Author

Okay

@coveralls
Copy link

coveralls commented Jun 22, 2020 •
edited

Pull Request Test Coverage Report for Build edbca2c9bbd0410fa6f81369c200d76806a36f2c-PR-2

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.051%
Changes Missing Coverage Covered Lines Changed/Added Lines %
asyncprawcore/sessions.py 1 3 33.33%
Totals Coverage Status
Change from base Build c3542d6a7f143b5dfb2e4250581763b5843ee1fd: 0.0%
Covered Lines: 359
Relevant Lines: 390
💛 - Coveralls

@LilSpazJoekp
Copy link
Member Author

@vikramaditya91 Could you transfer this to me please since I am the author of it. Thanks!

PythonCoderAS
PythonCoderAS suggested changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@PythonCoderAS PythonCoderAS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the minor typo corrections should be separated from the AUTHORS.RST inclusions.

@LilSpazJoekp
Copy link
Member Author

@vikramaditya91 Will this work?

@vikramaditya91
Copy link
Contributor

@PythonCoderAS , since most of the discussion has already been made here regarding the authors, I would like to merge it here itself

@PythonCoderAS PythonCoderAS merged commit 550bed2 into master Jun 22, 2020
@PythonCoderAS PythonCoderAS deleted the corrections branch June 22, 2020 15:55
@LilSpazJoekp
Copy link
Member Author

LilSpazJoekp commented Jun 22, 2020 •
edited

@vikramaditya91 would you mind joining the slack? https://join.slack.com/t/praw/shared_invite/zt-c4ggb0ap-7Q19mb2QEKbyvRLWDVZ5VA I'd love to have a place to easily chat. Never mind just saw you joined earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramaditya91 vikramaditya91 vikramaditya91 approved these changes

@PythonCoderAS PythonCoderAS PythonCoderAS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LilSpazJoekp @coveralls @PythonCoderAS @vikramaditya91