Merge pull request #1103 from Pyprohly/replies

Initialise `.replies` to an empty list
praw-dev · Jul 11, 2019 · 5aa2865 · 5aa2865
2 parents 6255a1a + 15299ed
commit 5aa2865
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/praw/models/reddit/comment.py b/praw/models/reddit/comment.py
@@ -142,10 +142,11 @@ def __init__(
             raise TypeError(
                 "Exactly one of `id`, `url`, or `_data` must be provided."
             )
-        self._replies = self._submission = None
+        self._replies = []
+        self._submission = None
         super(Comment, self).__init__(reddit, _data=_data)
         if id:
-            self.id = id  # pylint: disable=invalid-name
+            self.id = id
         elif url:
             self.id = self.id_from_url(url)
         else:

diff --git a/praw/models/reddit/live.py b/praw/models/reddit/live.py
@@ -346,7 +346,7 @@ def __init__(
             raise TypeError("Either `id` or `_data` must be provided.")
         super(LiveThread, self).__init__(reddit, _data=_data)
         if id:
-            self.id = id  # pylint: disable=invalid-name
+            self.id = id
 
     def _fetch_info(self):
         return ("liveabout", {"id": self.id}, None)
@@ -617,7 +617,7 @@ def __init__(self, reddit, thread_id=None, update_id=None, _data=None):
         elif thread_id and update_id:
             super(LiveUpdate, self).__init__(reddit, _data=None)
             self._thread = LiveThread(self._reddit, thread_id)
-            self.id = update_id  # pylint: disable=invalid-name
+            self.id = update_id
         else:
             raise TypeError(
                 "Either `thread_id` and `update_id`, or "

diff --git a/praw/models/reddit/modmail.py b/praw/models/reddit/modmail.py
@@ -141,7 +141,7 @@ def __init__(
             raise TypeError("Either `id` or `_data` must be provided.")
 
         if id:
-            self.id = id  # pylint: disable=invalid-name
+            self.id = id
 
         self._info_params = {"markRead": True} if mark_read else None
 

diff --git a/praw/models/reddit/submission.py b/praw/models/reddit/submission.py
@@ -196,7 +196,7 @@ def __init__(
         self.comment_sort = "best"
 
         if id is not None:
-            self.id = id  # pylint: disable=invalid-name
+            self.id = id
         elif url is not None:
             self.id = self.id_from_url(url)
 

diff --git a/tests/integration/models/reddit/test_comment.py b/tests/integration/models/reddit/test_comment.py
@@ -153,9 +153,11 @@ def test_parent__submission(self):
         assert parent.fullname == comment.parent_id
 
     def test_refresh(self):
+        comment = Comment(self.reddit, "d81vwef")
         with self.recorder.use_cassette("TestComment.test_refresh"):
-            comment = Comment(self.reddit, "d81vwef").refresh()
-        assert len(comment.replies) > 0
+            assert len(comment.replies) == 0
+            comment.refresh()
+            assert len(comment.replies) > 0
 
     def test_refresh__raises_exception(self):
         with self.recorder.use_cassette(