Skip to content

Commit

Permalink
Sort praw.models.reddit.subreddit.Subreddit._upload_media arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
LilSpazJoekp committed Jan 29, 2022
1 parent f66e269 commit 79d1b1c
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions praw/models/reddit/subreddit.py
Original file line number Diff line number Diff line change
Expand Up @@ -652,8 +652,9 @@ def _read_and_post_media(self, media_path, upload_url, upload_data):

def _upload_media(
self,
media_path: str,
*,
expected_mime_prefix: Optional[str] = None,
media_path: str,
upload_type: str = "link",
):
"""Upload media and return its URL and a websocket (Undocumented endpoint).
Expand Down Expand Up @@ -725,7 +726,7 @@ def _upload_inline_media(self, inline_media: "praw.models.InlineMedia"):
"""
self._validate_inline_media(inline_media)
inline_media.media_id = self._upload_media(
inline_media.path, upload_type="selfpost"
media_path=inline_media.path, upload_type="selfpost"
)[0]
return inline_media

Expand Down Expand Up @@ -1129,8 +1130,8 @@ def submit_gallery(
"caption": image.get("caption", ""),
"outbound_url": image.get("outbound_url", ""),
"media_id": self._upload_media(
image["image_path"],
expected_mime_prefix="image",
media_path=image["image_path"],
upload_type="gallery",
)[0],
}
Expand Down Expand Up @@ -1253,7 +1254,7 @@ def submit_image(
data[key] = value

image_url, websocket_url = self._upload_media(
image_path, expected_mime_prefix="image"
expected_mime_prefix="image", media_path=image_path
)
data.update(kind="image", url=image_url)
if without_websockets:
Expand Down Expand Up @@ -1478,13 +1479,13 @@ def submit_video(
data[key] = value

video_url, websocket_url = self._upload_media(
video_path, expected_mime_prefix="video"
expected_mime_prefix="video", media_path=video_path
)
data.update(
kind="videogif" if videogif else "video",
url=video_url,
# if thumbnail_path is None, it uploads the PRAW logo
video_poster_url=self._upload_media(thumbnail_path)[0],
video_poster_url=self._upload_media(media_path=thumbnail_path)[0],
)
if without_websockets:
websocket_url = None
Expand Down

0 comments on commit 79d1b1c

Please sign in to comment.