Sort praw.models.reddit.submission.SubmissionModeration.flair arguments

praw-dev · Jan 8, 2022 · a507032 · a507032
1 parent ab8e105
commit a507032
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/praw/models/reddit/submission.py b/praw/models/reddit/submission.py
@@ -125,19 +125,21 @@ def contest_mode(self, state: bool = True):
             API_PATH["contest_mode"], data={"id": self.thing.fullname, "state": state}
         )
 
+    @_deprecate_args("text", "css_class", "flair_template_id")
     def flair(
         self,
-        text: str = "",
+        *,
         css_class: str = "",
         flair_template_id: Optional[str] = None,
+        text: str = "",
     ):
         """Set flair for the submission.
 
-        :param text: The flair text to associate with the :class:`.Submission` (default:
-            ``""``).
         :param css_class: The css class to associate with the flair html (default:
             ``""``).
         :param flair_template_id: The flair template ID to use when flairing.
+        :param text: The flair text to associate with the :class:`.Submission` (default:
+            ``""``).
 
         This method can only be used by an authenticated user who is a moderator of the
         submission's :class:`.Subreddit`.

diff --git a/tests/integration/models/reddit/test_submission.py b/tests/integration/models/reddit/test_submission.py
@@ -329,37 +329,37 @@ def test_contest_mode__disable(self):
     def test_flair(self, _):
         self.reddit.read_only = False
         with self.use_cassette():
-            self.reddit.submission("4b536p").mod.flair("submission flair")
+            self.reddit.submission("4b536p").mod.flair(text="submission flair")
 
     @mock.patch("time.sleep", return_value=None)
     def test_flair_template_id(self, _):
         self.reddit.read_only = False
         with self.use_cassette():
             self.reddit.submission("eh9xy1").mod.flair(
-                "submission flair",
+                text="submission flair",
                 flair_template_id="0f7349d8-2a6d-11ea-8529-0e5dee3e1a9d",
             )
 
     @mock.patch("time.sleep", return_value=None)
     def test_flair_text_only(self, _):
         self.reddit.read_only = False
         with self.use_cassette():
-            self.reddit.submission("eh9xy1").mod.flair("submission flair")
+            self.reddit.submission("eh9xy1").mod.flair(text="submission flair")
 
     @mock.patch("time.sleep", return_value=None)
     def test_flair_text_and_css_class(self, _):
         self.reddit.read_only = False
         with self.use_cassette():
             self.reddit.submission("eh9xy1").mod.flair(
-                "submission flair", css_class="submission flair"
+                text="submission flair", css_class="submission flair"
             )
 
     @mock.patch("time.sleep", return_value=None)
     def test_flair_all(self, _):
         self.reddit.read_only = False
         with self.use_cassette():
             self.reddit.submission("eh9xy1").mod.flair(
-                "submission flair",
+                text="submission flair",
                 css_class="submission flair",
                 flair_template_id="0f7349d8-2a6d-11ea-8529-0e5dee3e1a9d",
             )