Sort praw.models.base.PRAWBase._safely_add_arguments arguments

praw/models/base.py

@@ -10,17 +10,17 @@ class PRAWBase:
     """Superclass for all models in PRAW."""
 
     @staticmethod
-    def _safely_add_arguments(argument_dict, key, **new_arguments):
-        """Replace argument_dict[key] with a deepcopy and update.
+    def _safely_add_arguments(*, arguments, key, **new_arguments):
+        """Replace arguments[key] with a deepcopy and update.
 
         This method is often called when new parameters need to be added to a request.
         By calling this method and adding the new or updated parameters we can insure we
         don't modify the dictionary passed in by the caller.
 
         """
-        value = deepcopy(argument_dict[key]) if key in argument_dict else {}
+        value = deepcopy(arguments[key]) if key in arguments else {}
         value.update(new_arguments)
-        argument_dict[key] = value
+        arguments[key] = value
 
     @classmethod
     def parse(cls, data: Dict[str, Any], reddit: "praw.Reddit") -> Any:

praw/models/inbox.py

@@ -333,5 +333,7 @@ def unread(
                     print(item.author)
 
         """
-        self._safely_add_arguments(generator_kwargs, "params", mark=mark_read)
+        self._safely_add_arguments(
+            arguments=generator_kwargs, key="params", mark=mark_read
+        )
         return ListingGenerator(self._reddit, API_PATH["unread"], **generator_kwargs)

praw/models/listing/mixins/base.py

@@ -26,7 +26,7 @@ def _validate_time_filter(time_filter):
     def _prepare(self, *, arguments, sort):
         """Fix for :class:`.Redditor` methods that use a query param rather than subpath."""
         if self.__dict__.get("_listing_use_sort"):
-            self._safely_add_arguments(arguments, "params", sort=sort)
+            self._safely_add_arguments(arguments=arguments, key="params", sort=sort)
             return self._path
         return urljoin(self._path, sort)
 
@@ -62,7 +62,9 @@ def controversial(
 
         """
         self._validate_time_filter(time_filter)
-        self._safely_add_arguments(generator_kwargs, "params", t=time_filter)
+        self._safely_add_arguments(
+            arguments=generator_kwargs, key="params", t=time_filter
+        )
         url = self._prepare(arguments=generator_kwargs, sort="controversial")
         return ListingGenerator(self._reddit, url, **generator_kwargs)
 
@@ -140,6 +142,8 @@ def top(
 
         """
         self._validate_time_filter(time_filter)
-        self._safely_add_arguments(generator_kwargs, "params", t=time_filter)
+        self._safely_add_arguments(
+            arguments=generator_kwargs, key="params", t=time_filter
+        )
         url = self._prepare(arguments=generator_kwargs, sort="top")
         return ListingGenerator(self._reddit, url, **generator_kwargs)

praw/models/reddit/subreddit.py

@@ -827,8 +827,8 @@ def search(
         self._validate_time_filter(time_filter)
         not_all = self.display_name.lower() != "all"
         self._safely_add_arguments(
-            generator_kwargs,
-            "params",
+            arguments=generator_kwargs,
+            key="params",
             q=query,
             restrict_sr=not_all,
             sort=sort,
@@ -1715,7 +1715,9 @@ def __call__(
                 print(flair)
 
         """
-        Subreddit._safely_add_arguments(generator_kwargs, "params", name=redditor)
+        Subreddit._safely_add_arguments(
+            arguments=generator_kwargs, key="params", name=redditor
+        )
         generator_kwargs.setdefault("limit", None)
         url = API_PATH["flairlist"].format(subreddit=self.subreddit)
         return ListingGenerator(self.subreddit._reddit, url, **generator_kwargs)
@@ -2292,7 +2294,9 @@ def _handle_only(*, generator_kwargs: Dict[str, Any], only: Optional[str]):
         if only is not None:
             if only == "submissions":
                 only = "links"
-            RedditBase._safely_add_arguments(generator_kwargs, "params", only=only)
+            RedditBase._safely_add_arguments(
+                arguments=generator_kwargs, key="params", only=only
+            )
 
     def __init__(self, subreddit: "praw.models.Subreddit"):
         """Initialize a :class:`.SubredditModeration` instance.
@@ -2401,7 +2405,9 @@ def log(
 
         """
         params = {"mod": str(mod) if mod else mod, "type": action}
-        Subreddit._safely_add_arguments(generator_kwargs, "params", **params)
+        Subreddit._safely_add_arguments(
+            arguments=generator_kwargs, key="params", **params
+        )
         return ListingGenerator(
             self.subreddit._reddit,
             API_PATH["about_log"].format(subreddit=self.subreddit),
@@ -3005,7 +3011,9 @@ def __call__(
         :class:`.ListingGenerator`.
 
         """
-        Subreddit._safely_add_arguments(generator_kwargs, "params", user=redditor)
+        Subreddit._safely_add_arguments(
+            arguments=generator_kwargs, key="params", user=redditor
+        )
         url = API_PATH[f"list_{self.relationship}"].format(subreddit=self.subreddit)
         return ListingGenerator(self.subreddit._reddit, url, **generator_kwargs)
 
@@ -3486,11 +3494,7 @@ def conversations(
         if self.subreddit != "all":
             params["entity"] = self._build_subreddit_list(other_subreddits)
         Subreddit._safely_add_arguments(
-            generator_kwargs,
-            "params",
-            sort=sort,
-            state=state,
-            **params,
+            arguments=generator_kwargs, key="params", sort=sort, state=state, **params
         )
         return ListingGenerator(
             self.subreddit._reddit,

praw/models/redditors.py

@@ -62,7 +62,7 @@ def search(
         :class:`.ListingGenerator`.
 
         """
-        self._safely_add_arguments(generator_kwargs, "params", q=query)
+        self._safely_add_arguments(arguments=generator_kwargs, key="params", q=query)
         return ListingGenerator(
             self._reddit, API_PATH["users_search"], **generator_kwargs
         )

praw/models/subreddits.py

@@ -123,7 +123,7 @@ def search(
             :meth:`.search_by_name` to search by subreddit names
 
         """
-        self._safely_add_arguments(generator_kwargs, "params", q=query)
+        self._safely_add_arguments(arguments=generator_kwargs, key="params", q=query)
         return ListingGenerator(
             self._reddit, API_PATH["subreddits_search"], **generator_kwargs
         )