Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'body-html' attribute to comment #1495

Closed
SJS830 opened this issue May 5, 2020 · 4 comments · Fixed by #1535
Closed

Add 'body-html' attribute to comment #1495

SJS830 opened this issue May 5, 2020 · 4 comments · Fixed by #1535
Labels
Documentation Documentation issue or improvement

Comments

@SJS830
Copy link

SJS830 commented May 5, 2020

When accessing a comment through the reddit api, all comments have a body-html attribute. But, there is no such feature for praw comments.

@SJS830 SJS830 changed the title Add 'body-html Add 'body-html' attribute to comment May 5, 2020
@jarhill0
Copy link
Contributor

jarhill0 commented May 5, 2020

Would you like to make a PR that adds this? It would mean modifying this file, as well as adding yourself to the authors file as a documentation contributor.

@PythonCoderAS
Copy link
Contributor

There are multiple classes which have this attribute that are undocumented. Anything that is in markdown has a html counterpart to my knowledge.

@PythonCoderAS PythonCoderAS added the Documentation Documentation issue or improvement label May 6, 2020
@nickatnight
Copy link
Contributor

Is this ticket still valid? I see that body_html is available for Comment() in the latest version of praw, it's just not documented? Maybe I'm just not following the ask here. Anyway, guess I'll open a PR?

@jarhill0
Copy link
Contributor

jarhill0 commented Jul 2, 2020

@nickatnight Based on my comment, it looks like I interpreted the request to be for this attribute to documented. You can do reddit.comment('some_id').body_html today just as you could in May, so the attribute exists.

I see that you made a PR that will close this issue. Thanks!

jarhill0 added a commit that referenced this issue Jul 2, 2020
…-html-attribute-to-comment

docs: add body_html to doc strings..update AUTHORS.rst [#1495]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation issue or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants