Format code using the tool black #1039
Conversation
|
Out of curiosity, is this a one-time format or will it enforce style going forward? Either way, I'm in favor of consistent style! |
This change incorporates it as part of the |
bboe
force-pushed
the
black_format
branch
8 times, most recently
from
269b792
to
89683e1
Compare
| success &= do_process('pydocstyle', 'praw') | ||
| success &= do_process('pylint', '--rcfile=.pylintrc', 'praw') | ||
| success &= do_process(["black -l 79 *.py docs praw tests"], shell=True) | ||
| success &= do_process(["flake8", "--exclude=.eggs,docs,.tox"]) |
There was a problem hiding this comment.
Flake8 is spamming loads of “Q000 Remove bad quotes” messages because of black’s formatting. Can we have --ignore=Q000 be added to this command?
There was a problem hiding this comment.
What version of flake8 do you have? Do you happen to have flake8-quotes installed? Perhaps that's resulting in the issues.
3.7.7 (mccabe: 0.6.1, pycodestyle: 2.5.0, pyflakes: 2.1.1) CPython 3.7.2 on Darwin
That's what I'm running?
There was a problem hiding this comment.
I do happen to have flakes8-quotes installed.
3.7.5 (flake8_quotes: 1.0.0, mccabe: 0.6.1, pycodestyle: 2.5.0, pyflakes: 2.1.0) CPython 3.7.2 on Darwin
| success &= do_process(["black -l 79 *.py docs praw tests"], shell=True) | ||
| success &= do_process(["flake8", "--exclude=.eggs,docs,.tox"]) | ||
| success &= do_process(["pydocstyle", "praw"]) | ||
| # success &= do_process(["pylint", "--rcfile=.pylintrc", "praw"]) |
There was a problem hiding this comment.
Why is pylint commented out?
There was a problem hiding this comment.
I didn't satisfactorily resolve the issues it was complaining about after adding in black for source code formatting. So I've commented it out. Getting pylint to pass has never been terribly important as it's never been part of CI. I like to run it periodically to see if its report has anything useful, however.
No description provided.