Add support for building on python3.8 #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.8 should be back-compatible with everything on the previous versions, and I use python3.8 for testing all the code, so it's proven to work correctly.
bboe
approved these changes
Dec 22, 2019
|
Should we add a line here as well: https://github.com/praw-dev/praw/blob/master/setup.py#L33 |
Sure, if you want you can start a PR on my branch, but I am going to implement that change now. |
Add "Programming Language :: Python :: 3.8"
|
Thanks! I love these great efforts of your. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 should be back-compatible with everything on the previous versions, furthermore, I have run the pre_push checks and the unit tests on 3.8 without any new syntax errors or DeprecationWarnings.