Remove unicode string indicatiors

[PythonCoderAS]

While writing stubs, I was looking through the code and realized there is still a lot of Python2 compliant code. This was a simple fix to remove unicode prefixes on a bunch of items. However, several things still do a whole bunch of weird things to deal with unicode. An example is the Praw API Exception, which escapes unicode characters. In Python3, this should not be done, and I will implement a fix for that later.

[PythonCoderAS]

A commit like my recent commit is going to break programs that rely on the given behavior of unicode escaping. Should I build in a method to do it or just note that they need to escape on their own?

[PythonCoderAS]

Here is a git patch (compressed as a gzip to support uploading) to get the python util that I was using to find the changes and approve them.
Find_unicode_strings_and_future_imports.patch.gz

[bboe]

I think we can delete the one assertion, otherwise, this change looks great.

[bboe]

As this is a breaking change I'm going to hold off on merging it for now until after our next minor release. It would be great to make a PR that only has deprecation changelog entry indicating that in the next release we'll change this behavior.

[PythonCoderAS]

@bboe got it but you are always welcome of making PRs onto my branches as well :)

[bboe]

@bboe got it but you are always welcome of making PRs onto my branches as well :)

For sure. Unfortunately, I really only have time to review, and I'm barely keeping up at that ;).

[PythonCoderAS]

Lol I have break and I'm an HS student so I got all the time on my hands :)