Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1177) Add a new SubmissionModerationFlair class #1226

Closed
wants to merge 19 commits into from
Closed

(#1177) Add a new SubmissionModerationFlair class #1226

wants to merge 19 commits into from

Conversation

PythonCoderAS
Copy link
Contributor

Fix for issue #1177

Still needs some integration tests but I do not have an account that I can use user/pass with that also has a subreddit so I am unable to run any integration tests.

Furthermore, when trying to update the changelog, it causes a whole bunch of issues so I had to go change entries from PRAW5 and earlier.

Copy link
Member

@bboe bboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding integration tests, I create a few test subreddits for my test accounts to be a moderator of.

praw/models/reddit/submission.py Outdated Show resolved Hide resolved
praw/models/reddit/submission.py Outdated Show resolved Hide resolved
praw/models/reddit/submission.py Outdated Show resolved Hide resolved
@PythonCoderAS
Copy link
Contributor Author

@bboe can you make my alt mod in order for me to generate the tests?

@PythonCoderAS
Copy link
Contributor Author

It's so exciting when coveralls fails. These tests need to be re-run

@bboe
Copy link
Member

bboe commented Dec 29, 2019

@bboe can you make my alt mod in order for me to generate the tests?

You should be able to create your own subreddit(s) and make your alt(s) mod on them.

@bboe
Copy link
Member

bboe commented Dec 29, 2019

It's so exciting when coveralls fails. These tests need to be re-run

If you rebase you can force push thus triggering a new build yourself. You can also do a similar trick by slightly modifying your commit message via git commit --amend to result in a new commit and then force-push to your branch.

@PythonCoderAS
Copy link
Contributor Author

Once I get onto a PC I’ll merge fix that.

@PythonCoderAS
Copy link
Contributor Author

@bboe can you finish reviewing this PR? Also help out at gitter please

@bboe
Copy link
Member

bboe commented Dec 30, 2019

I unfortunately won't have the time to dig into this PR today. Possibly tomorrow, but it might not be until next weekend for me.

@PythonCoderAS
Copy link
Contributor Author

@jarhill0 can you review this PR?

@jarhill0
Copy link
Contributor

jarhill0 commented Jan 3, 2020

The changes are too much for me to look at today, but I may be able to review it in the coming days.

@PythonCoderAS
Copy link
Contributor Author

Closing to merge with new branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants