-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1177) Add a new SubmissionModerationFlair class #1226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding integration tests, I create a few test subreddits for my test accounts to be a moderator of.
@bboe can you make my alt mod in order for me to generate the tests? |
It's so exciting when coveralls fails. These tests need to be re-run |
You should be able to create your own subreddit(s) and make your alt(s) mod on them. |
If you rebase you can force push thus triggering a new build yourself. You can also do a similar trick by slightly modifying your commit message via |
Once I get onto a PC I’ll merge fix that. |
# Conflicts: # praw/models/reddit/submission.py
@bboe can you finish reviewing this PR? Also help out at gitter please |
I unfortunately won't have the time to dig into this PR today. Possibly tomorrow, but it might not be until next weekend for me. |
@jarhill0 can you review this PR? |
The changes are too much for me to look at today, but I may be able to review it in the coming days. |
Closing to merge with new branch |
Fix for issue #1177
Still needs some integration tests but I do not have an account that I can use user/pass with that also has a subreddit so I am unable to run any integration tests.
Furthermore, when trying to update the changelog, it causes a whole bunch of issues so I had to go change entries from PRAW5 and earlier.