Fix OS-dependent error in upload_image. #154
Conversation
|
You're right. In that case, we might as well just require the user to pass a path to the file, rather than the file itself since it already requires the file to be saved to disk (StringIO doesn't work). I really don't like forcing opening in binary mode to occur when it isn't necessary on many systems. Are you up for making that change? |
|
Sure. I'll make that change right away. |
|
And the white-square file isn't broken. It's a symbolic link. Odds are if you're using Windows you probably need to configure something to handle the link specially. |
Great. No need to test that the file exists. If it doesn't let python raise the IOException. |
| @@ -755,7 +758,8 @@ def upload_image(self, subreddit, image, name=None, header=False): | |||
| elif first_bytes.startswith(PNG_HEADER): | |||
| image_type = 'png' | |||
| else: | |||
| raise errors.ClientException('`image` is not a valid image') | |||
There was a problem hiding this comment.
Please word this:
`image` must be either a jpg or png
This fixes problems coming from opening the image file in incorrect mode.
|
Merged, thanks for the prompt fix. |
Some operation systems, such as windows, treat binary and text files
differently. For them opening an image with 'r' and not 'rb' would
cause the cryptic ClientException '
imageis not a valid image'.The same would also be true if the mode was some varient of 'w'
irrespective of OS.
Also, the old
white-squarefile was a copy of theinvalidfile notwhite-square.jpg, which causedtest_jpg_no_extensionto fail for the minimum size requirement.