Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission URL error handling fix #1564

Merged
merged 1 commit into from Oct 26, 2020
Merged

Submission URL error handling fix #1564

merged 1 commit into from Oct 26, 2020

Conversation

Cyatos
Copy link
Contributor

@Cyatos Cyatos commented Sep 25, 2020

Fixes #1553

Simple fix raising the correct error in case of invalid submission URL

@bboe
Copy link
Member

bboe commented Oct 26, 2020

Can you please rebase and resolve the conflicts?

@Cyatos
Copy link
Contributor Author

Cyatos commented Oct 26, 2020

Can you please rebase and resolve the conflicts?

Done

@LilSpazJoekp
Copy link
Member

Can you please also squash your commits?

@Cyatos
Copy link
Contributor Author

Cyatos commented Oct 26, 2020

Can you please also squash your commits?

My bad, I should've done this in the first place. It's done now!

@LilSpazJoekp
Copy link
Member

Thanks for the PR!

@LilSpazJoekp LilSpazJoekp merged commit d022c7f into praw-dev:master Oct 26, 2020
@Cyatos
Copy link
Contributor Author

Cyatos commented Oct 28, 2020

Thanks for the PR!

Happy to help!

@LilSpazJoekp LilSpazJoekp mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilSpazJoekp LilSpazJoekp LilSpazJoekp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IndexError on Invalid URL to Submission
3 participants
@Cyatos @bboe @LilSpazJoekp