Type subreddit #1587
Type subreddit #1587
Conversation
| from urllib.parse import urljoin | ||
| from xml.etree.ElementTree import XML | ||
|
|
||
| import websocket | ||
| from prawcore import Redirect | ||
| from requests import Response |
There was a problem hiding this comment.
It looks like Response is only used in a type signature. Should this be under if TYPE_CHECKING:?
I'm not very familiar with the intricacies of Python's typing, so I'm just curious.
There was a problem hiding this comment.
I imported Response because it doesn't interfere with the import chain. I put under if TYPE_CHECKING anything that could cause a circular import loop, or anything else that I imported from PRAW. However, I highly doubt a third-party package would form such a loop.
|
Could you resolve conflicts? |
|
Could you please run pre-push again? It looks black is having issues with it. |
|
Could you rebase the changes from master instead of merge please? |
|
Can you merge and squash? |
|
I would prefer if you did a rebase. Squash and merge doesn't create a merge commit. |
|
Could you rebase and squash please? |
|
I'll get this finished up for you. |
|
This PR is dependent on #1681 being merged. |
This is the typed version of subreddit.py