Bugfix/coveralls GitHub action updated

[vikramaditya91]

The coverallsapp in GitHub actions was pinned to a particular commit from a year ago. It was done here #1402
This branch pins itself to the master branch of coverallsapp to avoid technical debt.

Also, for the coveralls command, it uses the https://coveralls-python.readthedocs.io/en
instead of https://github.com/bboe/coveralls-python/archive/github_actions.zip
But the coveralls-python seems to be maintained and up to date.
I am not too convinced about this.

FYI: Ideally, we would not be using the coveralls command in section: Submit to coveralls. But because of this issue coverallsapp/github-action#30 this seems to be the simpler choice

[LilSpazJoekp]

FYI: Ideally, we would not be using the coveralls command in section: Submit to coveralls. But because of this issue coverallsapp/github-action#30 this seems to be the simpler choice

Could you elaborate on this? What we are currently doing works for Coveralls and your change does too.

[vikramaditya91]

@LilSpazJoekp
The official coverallsapp's documentation suggests running the coverage through this pattern

    - name: Coveralls Parallel
      uses: coverallsapp/github-action@master
      with:
        github-token: ${{ secrets.GITHUB_TOKEN }}
        flag-name: run-${{ matrix.python-version }}
        parallel: true

The advantage of this method is that it removes dependency on the python package coveralls.

https://github.com/vikramaditya91/praw/commit/fb6a0dcc565bbcfb9ac2b484047c4fe2c93bd272#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f

However, as you can see in the GH actions of that above commit, it crashes with

 Using lcov file: ./coverage/lcov.info
Error: Lcov file not found.

This is because pytest coverage does not generate a lcov file as also stated in this issue coverallsapp/github-action#30

That is the reason, I had to still use the coveralls to push the generated .coverage file to coveralls.

If one day, they allow using the results from the coverage results in the line

coverage run --source praw --module pytest

then we can fully ditch the coveralls package which would be unnecessary here.