Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommentForest: replace_more typing #1932

Merged
merged 2 commits into from
Jan 24, 2023
Merged

CommentForest: replace_more typing #1932

merged 2 commits into from
Jan 24, 2023

Conversation

timendum
Copy link
Contributor

Feature Summary and Justification

Just a small change in the CommentForest.replace_more method: limit can be None, as per documentation.

A small question: Praw has typing annotation but it's not published annotated, is that intended?

@LilSpazJoekp
Copy link
Member

Praw has typing annotation but it's not published annotated, is that intended?

Could you elaborate?

@timendum
Copy link
Contributor Author

@LilSpazJoekp

I am by no means an expert in the field, but I've found this informatio.

Also, when I import praw as a dependency, mypy doesn't find any type for praw.

module is installed, but missing library stubs or py.typed marker

@LilSpazJoekp
Copy link
Member

Seems simple enough to implement. If you'd like you could open a separate MR for this.

@LilSpazJoekp LilSpazJoekp merged commit b64fc3a into praw-dev:master Jan 24, 2023
@timendum
Copy link
Contributor Author

timendum commented Feb 1, 2023

@LilSpazJoekp

To publish the type hinting, we must find a solution for attributes, otherwise there will be errors on any submission.title like, because attributes are coming from Reddit and mypy (or others) reports error.

@LilSpazJoekp
Copy link
Member

Not sure how that's possible. Most attribute are dynamic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants