Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade setup #1971

Merged
merged 2 commits into from Aug 31, 2023
Merged

Upgrade setup #1971

merged 2 commits into from Aug 31, 2023

Conversation

LilSpazJoekp
Copy link
Member

Fixes # (provide issue number if applicable)

Feature Summary and Justification

This pull request provides ...

References

@LilSpazJoekp LilSpazJoekp force-pushed the upgrade_setup branch 3 times, most recently from 7a4a4db to 2c70bd5 Compare August 31, 2023 21:31
bboe
bboe approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@bboe bboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I see is to return 0 by default in the main methods.

.pre-commit-config.yaml Show resolved Hide resolved
tools/bump_version.py Outdated Show resolved Hide resolved
tools/set_active_docs.py Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@LilSpazJoekp LilSpazJoekp merged commit 1e90581 into master Aug 31, 2023
28 checks passed
@LilSpazJoekp LilSpazJoekp deleted the upgrade_setup branch August 31, 2023 23:55
@LilSpazJoekp LilSpazJoekp mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboe bboe bboe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LilSpazJoekp @bboe