New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for an initial before_attribute in stream_generator #1983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for a few concerns.
Could you also add an entry in CHANGES.rst?
For CHANGES.rst, should I increment the version number? (And if so do I need to do that elsewhere as well?) Or should I put it in Unreleased? |
Put it in unreleased under the |
Requested changes have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I just have a final couple of comments.
Merged in! 🎉Thank you! |
Thanks for all your help! |
By the way, question: what's the release schedule of PRAW like? I want to use this in a project of mine but not sure if to just wait or to hack around it in the meantime |
There isn't really a release schedule. However, you can do |
Adds a
continue_after_id
parameter to the stream_generator function so that an initial value for before_attribute can be set.Example use case: a script wants to process all new comments from a sub since the last time it's been run. It keeps the fullname of the last comment it saw on its previous run and wants to stream all comments starting from the one after that. It can do: