Praw 19 November -- Early support for Multireddits #345
Conversation
Added Multireddit class to objects.py, added multireddit api endpoints to init's config, added get_multireddit and get_my_multis, which is not 100% functional yet.
get_multireddit and get_my_multis are now fully functional. Added LabeledMulti as a recognized kind. New class MultiredditTest will test get_my_multis, existing class BasicTest will test get_multireddit
Fixed typo in CHANGES.rst
Added comment to __init__.py regarding why we don't use get_content for get_my_multireddits. Cleaned up pep8
Added a forward slash to the end of the multireddit_about endpoint even though it may not be necessary. Fixed the docstring of get_my_multis to remove references to the get_content function.
Fixed test on get_multireddit which caused travis build to fail.
| @@ -124,10 +124,13 @@ class Config(object): # pylint: disable-msg=R0903, R0924 | |||
| 'morechildren': 'api/morechildren/', | |||
| 'my_con_subreddits': 'subreddits/mine/contributor/', | |||
| 'my_mod_subreddits': 'subreddits/mine/moderator/', | |||
| 'my_multis': '/api/multi/mine/', | |||
There was a problem hiding this comment.
Leading '/' not required on these added paths.
Parameters for getting multireddits are now called "redditor" and "multi" across the board. Redditor objects have helper function get_multireddit to get one of their multis. Added test cases for Redditor.get_multireddit and Multireddit.get_new. Handled /me/m/ redirect.
Are you referring to the _get_sorters here? I tried every one manually and confirmed in-browser, they all work perfectly. My only problem with them is that they are a waste of lines since I copied them straight from Subreddit. One alternative would be to put those in a separate class then have Subreddit and Multireddit inherit, right? I have made the other changes you asked, and added Redditor.get_multireddit. When navigating to a subreddit you own, you are redirected to reddit.com/me/m/multi, this was raising an error in get_content because Multireddit._url is in /user/redditor/m/multi format. I felt that the best solution was to do a check and swap before request_json. At first, I initialized Multireddits with a /me/ url if it belonged to the user, but this would have caused problems if the session was later logged into a different user. Please critique. Edit: Edit2: Thanks |
|
Your latest commit has created conflicts with this pull. Should I resolve those or do you manage that during the pull process? Are there any other changes you were waiting for me to make? |
|
I'll take care of the merge issues. Thanks! |
|
Merged as 434d6ab. Thanks! |
|
Great! I'll get started on the features such as creation, copying, deletion, etc. |
New :class:
Multiredditfor multireddit objects. Proper endpoints and kind added to init configNew :meth:
get_multiredditto get a single mr object. Standard usage:r.get_multireddit(multi_author, multi_name)New :meth:
get_my_multiswhich requires logged in scope. Returns a list of all multireddit objects you own.New :class:
MultiredditTestin tests which will test the get_my_multis function. As of writing, :class:BasicTestwill test get_multireddit since that does not require logged in.Added proper material to CHANGES.rst
Edit: Travis build failed but I see the error and will re-commit.
Sorry for the commit-flood :( I will learn to squash before next time.
Edit: Build 498 failed on account of test_scope_submit timing out (Line 415). Can a new build be initiated without a commit?