Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds get_sticky function to Subreddit object #403

Closed
wants to merge 1 commit into from
Closed

Adds get_sticky function to Subreddit object #403

wants to merge 1 commit into from

Conversation

diceroll123
Copy link
Contributor

My attempt at fixing my own issue, issue #402.

Unsure how to go about the 404 though, since this is new for praw. I figured since trying to view /r/lounge as a non-gilded user gives a 403 that I'd leave the 404 here for someone with more input on praw to decide.

My attempt at fixing my own issue, issue #402
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) to 71.42% when pulling 7c2ff0a on diceroll123:master into 50afdc6 on praw-dev:master.

@bboe
Copy link
Member

bboe commented Apr 25, 2015

This PR looks awesome!. A few things:

It would be perfect if you could make those changes, but if you think you may not get around to them please let me know. Thanks for the contribution!

@diceroll123
Copy link
Contributor Author

Thanks!

Also, while I'm sure I could hack together a way to do what you ask, I feel a little weary since I have no previous examples to follow the "style" of going about this. There aren't really any raised APIExceptions to learn off of for this isolated 404 (error messages and such...), so I'll leave this to someone who'd set a better standard. 👍

Though I'm glad I've given a slight nudge in the right direction for now. :)

@bboe
Copy link
Member

bboe commented Apr 26, 2015

@diceroll123 no worries. I'll work with what you have here. Thanks again!

@bboe
Copy link
Member

bboe commented Apr 27, 2015

Merged as 7f8f77d with additions and modifications in: 7a2ec7d

Thanks for the contribution!

@bboe bboe closed this Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants