Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change disliked and liked to downvoted and upvoted #412

Closed
wants to merge 2 commits into from

Conversation

justcool393
Copy link

Reddit recently changed the URLs for /user//disliked/ and /user//liked/.
reddit-archive/reddit@35339be

Reddit recently changed the URLs for /user/<name>/disliked/ and /user/<name>/liked/.
reddit-archive/reddit@35339be
@bboe
Copy link
Member

bboe commented May 22, 2015

Thanks for the effort. This PR is incomplete however as it only is updating the eviction urls. Would you like to update the endpoints for get_liked and get_disliked as well?

@justcool393
Copy link
Author

Added. https://reddit.com/user/PyAPITestUser2/upvoted seems to be set to private, so it got 403s when trying to get it.

@bboe
Copy link
Member

bboe commented Jun 3, 2015

Thanks for the update. It looks like there are some lint issues, and some of the test cassettes need to be updated. Can you take a look at those?

https://travis-ci.org/praw-dev/praw/jobs/63743280

To run the tests locally execute: python setup.py test. If you have any questions please do not hesitate to ask.

@bboe
Copy link
Member

bboe commented Jun 26, 2015

@justcool393 thanks for the effort to make the change. PR #429 was a bit more complete so decided to merge that one in. I look forward to any further contributions you have.

@bboe bboe closed this Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants