Support link_flair endpoint #815
Conversation
praw/models/reddit/subreddit.py
Outdated
| than a Redditor flair template (default: False). | ||
| :param is_link: (boolean) When None, choose a template type in a | ||
| subclass-defined way. Otherwise, add a link flair template when | ||
| True and a Redditor flair template when false (default: None). |
There was a problem hiding this comment.
This docstring has the potential to be fairly confusing. Without the latest commit, we could just have separate docstrings in different subclasses, but at the cost of a lot of duplication.
leviroth
force-pushed
the
link-flair-templates
branch
2 times, most recently
from
5a57a0d
to
949139e
Compare
There was a problem hiding this comment.
For the time being can we make private methods in the parent class, e.g., _add, and _clear which take in the necessary arguments and do the actually work.
Then we have add, and clear precisely defined in each non-abstract class with no need for an is_link attribute.
The gotcha, is that we should release a minor version of PRAW with is_link deprecated for the existing behavior. Then we can remove it as part of PRAW5.
But for the purposes of this PR let's ignore that part and simply clean it up. I'm not worried about people on the development version having things break (that's to be expected).
leviroth
force-pushed
the
link-flair-templates
branch
from
949139e
to
02a53c5
Compare
|
Is this what you had in mind? |
leviroth
force-pushed
the
link-flair-templates
branch
from
02a53c5
to
a248fdf
Compare
Yes, awesome. Can you add the changelog entry for the addition of the link template, and a removal for the support of the |
leviroth
force-pushed
the
link-flair-templates
branch
from
a248fdf
to
a5fff72
Compare
|
Added and squashed. |
|
Wonderful work thanks. I'll work pulling this into a backport in order to properly deprecate the |
Fixes #812.
I tried a couple different approaches to getting rid of the
is_linkparameters. I wanted to keep it around since existing code might do something like:The latest commit removes a lot of code duplication, and it seemed to me like the best approach.