Test improvements and upgrade pre_push script #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilSpazJoekp
commented
Jul 29, 2021
prawcore/auth.py
Outdated
| @@ -64,8 +64,7 @@ def authorize_url(self, duration, scopes, state, implicit=False): | |||
| ) | |||
| if implicit and duration != "temporary": | |||
| raise InvalidInvocation( | |||
| "The implicit grant flow only supports " | |||
| "temporary access tokens." | |||
| "The implicit grant flow only supports " "temporary access tokens." | |||
There was a problem hiding this comment.
Yes, it would appear so.
|
Alright. Looks good. I do not have permission to approve but no further comments from my side. |
|
Thank you, I am waiting for @bboe's approval before I merge. |
|
Seems like this PR stalled, but to greatly simplify maintenance, now that praw-dev/praw#1784 is merged and this has apparently picked up merge conflicts (GitHub won't show me them for some reason), it might be a good idea to just re-sync with that, and in the future, all that will be necessary to keep them in sync is |
LilSpazJoekp
force-pushed
the
pre_push
branch
2 times, most recently
from
42835df
to
5676c97
Compare
LilSpazJoekp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.