Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest GPLv2 revision #8

Merged
merged 1 commit into from Dec 18, 2012
Merged

Conversation

strzibny
Copy link
Member

@strzibny strzibny commented Dec 3, 2012

Hello,

The GPLv2 included with this gem is outdated and that causes a legal issue when packaging for Fedora. The latest official revision can be found at http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.

This pull request simply updates the license.

Thanks
Josef

@bradediger
Copy link
Member

@sandal What's the nature of our contributor agreement, if any? Do we need permission from each contributor to relicense or can the project do it on its own?

@yob
Copy link
Member

yob commented Dec 3, 2012

I'll admit to being a bit ignorant of licenses - I usually stick an MIT license file in my projects and forget about it. I didn't even know there were multiple versions of GPLv2.

@strzibny - what's the nature of the legal issue for Fedora, and what's the substance of the changes in the license?

@bradediger
Copy link
Member

@yob The basic issue I see is that if people gave us code under a particular license (such as "this version of the GPLv2"), we can't just rerelease it under a different license without their permission. If they gave us copyright assignment, we are fine. If they gave us generic "GPLv2" wording, well then, I guess it's a gray area.

@practicingruby
Copy link
Member

@bradediger: We never explicitly said "This exact version of the GPLv2", so I'd assume that we can change this without asking everyone. If you want to be careful, send a notice to each contributor and let them know to respond on this ticket within N days if they have concerns.

We don't have any sort of contributor agreement, because I feel strongly against copyright assignment, and it isn't even legal in some countries.

@practicingruby
Copy link
Member

@yob @bradediger : If you look at the diff on GPLv2, it looks like it only updates some fairly trivial things: FSF renamed LGPL from "Library GPL" to "Lesser GPL" and this reflects that change, and the address for the FSF changed as well. Other than that, looks to just be whitespace adjustments.

@bradediger
Copy link
Member

Thanks @sandal.

@yob @cheba @henrik @fnando @jonsgreen @Bluejade @piglop @casper: Thank you for your contributions to pdf-inspector. For legal reasons (see upthread), we need to bump the GPLv2 to the latest version. Are there any objections? If we don't hear significant objections within 14 days (by 17 December 2012), we will relicense. Thanks!

@yob
Copy link
Member

yob commented Dec 3, 2012

fine with me

@henrik
Copy link
Contributor

henrik commented Dec 3, 2012

And with me.

On Mon, Dec 3, 2012 at 3:36 PM, James Healy notifications@github.comwrote:

fine with me


Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-10955296.

@strzibny
Copy link
Member Author

strzibny commented Dec 3, 2012

Thanks guys, from my point of view this newer version doesn't change much and I don't think it even can. So its more of a cosmetic issue.

From Fedora wiki [1]:

"The license file, usually COPYING, must not be patched for legal reasons. Other files can be patched if deemed suitable. The updated GPL 2.0 license (the usual case) with correct address is at GPL-2.0.txt"

It basically says that your version looks like a patched version of the license even that's not the truth (it's just not updated).

[1] https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

@bradediger
Copy link
Member

Thanks @strzibny. I agree that the changes are extremely minor, but I'd rather make sure we don't have any significant objections from contributors before merging.

@sigmike
Copy link
Contributor

sigmike commented Dec 3, 2012

Fine with me too.

@pointlessone
Copy link
Member

No objections, of course.

bradediger added a commit that referenced this pull request Dec 18, 2012
Update to the latest GPLv2 revision
@bradediger bradediger merged commit a8f5b42 into prawnpdf:master Dec 18, 2012
@bradediger
Copy link
Member

Merged. Thanks @strzibny!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants