fixes issue #3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #3.
Earlier code checked on a cell by cell basis if it fits on the page. Now when the first (column 0) cell in a row is evaluated it checks if the whole row fits on the page otherwise breaking to a new page.
I added a function height_with_span to cells.rb which returns the height including any spanned cells if the spanning cell is the master cell.
The height method (cells.rb) is a little misleading. It returns only the height excluding spanned cells.
To ensure the row heights calculation is not run unnecessarily it will only be done on the first (column 0) cell in a row.