Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push New Version to Ruby Gems to Deal with Ruby 3.1 Removing Matrix #1318

Closed
pmichaeljones opened this issue Nov 4, 2023 · 6 comments
Closed

Comments

@pmichaeljones
Copy link

Hi guys,
You added a dependency on May 31, 2021 here: 3658d5125c3b20eb11484c3b039ca6b89dc7d1b7

spec.add_dependency('matrix', '~> 0.4')

That was the Ruby 3.1 fix for when they removed matrix as a default Ruby gem.

You haven't, however, pushed a new version to Ruby Gems to deal with this change, so Prawn 2.4.0 with Ruby 3.1 crashes because it needs matrix but the dependency doesn't show up.

I'm guessing this gem is no longer actively maintained and I could install the gem directly from git, but I thought I'd ask.

Thanks,
Patrick

@pointlessone
Copy link
Member

  • One option is to install from git. You'll get a few other fixes, too.
  • Another is to add matrix to your app's dependencies until a new gem is cut.
  • Yeah, you can say this gem is passively maintained. There will be a new gem eventually. That's on my bucket list.
  • That said, we already have a release request so I'll mark it a duplicate of Release a version #1195. Join the party there.

@pmichaeljones
Copy link
Author

Thanks man! I added matrix to my gemfile and all is well. 🥳

@pmichaeljones
Copy link
Author

pmichaeljones commented Nov 4, 2023

Newb question. If I install from git and don't specify a specific commit SHA, will it keep updating an app's gem to the newest SHA for every deployment?

Basically, when I deploy to Heroku, it bundles the gems. Will it always pull the newest SHA if I don't specify a specific one?

@pointlessone
Copy link
Member

It would do the same thing as for a gem without a version specified. If you have a Gemfile.lock it would not unless you ask. If you don't it would pull the latest commit.

@pmichaeljones
Copy link
Author

pmichaeljones commented Nov 4, 2023

Thanks man! Really love using Prawn. It's been a huge help for building PDF reports! 👏👏👏

@jgarber623
Copy link

Looks like v2.5.0 was recently released which includes the matrix gem in this project's gemspec and in the published version's metadata file. 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants