Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit failing UTF-8 test case for Line Wrap #693

Merged
merged 1 commit into from Mar 10, 2014

Conversation

johnnyshields
Copy link
Contributor

I am experiencing character conversion issues in the LineWrap module. Using Ruby 1.9.3 on Windows. I've provided an example test case which gives:

Encoding::CompatibilityError: incompatible encoding regexp match (ASCII-8BIT regexp with UTF-8 string)

@johnnyshields
Copy link
Contributor Author

In some cases I get the opposite error (UTF-8 regexp with ASCII-8BIT string)

@practicingruby
Copy link
Member

This seems like it may be a related issue to #603, captured at a lower level. I'll make a minor tweak and merge.

@practicingruby practicingruby merged commit 78272e2 into prawnpdf:master Mar 10, 2014
@practicingruby
Copy link
Member

@johnnyshields I added a couple tags to prevent our CI from breaking, but otherwise kept your test as-is.

Because you've successfully had a pull request accepted to Prawn, you've now been given commit access to all our repositories! Please see the contribution guidelines here: https://github.com/prawnpdf/prawn/wiki/Contributor-welcome-notes

Thanks!

@johnnyshields
Copy link
Contributor Author

@sandal, thank you. Looks like #603 is the main problem I'm having.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants