Use the correct value for preferred family name. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context "with DejaVuSans" do | ||
| let!(:file) { TTFunk::File.open(test_font("DejaVuSans"))} | ||
| it "should extract the correct value" do | ||
| puts "DOING #{file.name.preferred_family.first}" |
There was a problem hiding this comment.
Debugging line should probably be removed.
|
The spec you linked is the OpenType spec, which I think is based on TrueType, but I'm unsure what's different about it (if anything). That said, I found the same information in TTF spec: I will merge this as soon as I have a chance to test it out in Prawn. Thanks! |
practicingruby
added a commit
that referenced
this pull request
Jun 23, 2014
Use the correct value for preferred family name.
|
@marcusramberg: You now have commit access to all of Prawn's repositories. Please see our contribution guidelines for details, and thanks again for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value 16 is the correct value according to spec.
http://www.microsoft.com/typography/otspec/name.htm