-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmap table 14 fix #20
Conversation
- ignore cmap tables with a format number > 14 (CJK fonts) - migrate rspec expectations to expect API
Cmap subtables already have a method to determine whether they're supported, so we can use that rather than making a numeric comparison. This covers the format 2 edge case, and feels more maintainable to me. @mojavelinux Please confirm that this still fixes the problem for you. If so, I'll merge. |
Super! You captured the essence of my pull request and came up with a proper API to fix it. A total win. 🍻 |
And for our friends in the Linux distros that will inevitably ask the question, it appears that the M+ font is freely licensed: http://en.wikipedia.org/wiki/M%2B_Fonts#Licensing |
👍 Fix confirmed! |
Thanks again for taking time out of your day to address this issue. I really appreciate your efforts. |
Yes, I forgot to mention the licensing for M+. Here's the clause I managed to track down when I included it in another open source project:
|
I've cut a TTFunk release and updated the stable / master branches of Prawn to use it. You can try those out if you want to confirm the fix in production. |
Fantastic. I'll update my libraries asap. I confirmed it in a local installation of a toolchain that uses it. I can guarantee I'll know whether this works in production because the client will be quick to inform if it doesn't (I have very high confidence they are going to be sailing smoothly now, though). |
Thanks for the patch! Because it was accepted, you now have commit access to all of Prawn's repositories. Please read our contributor guidelines here, and happy hacking! |
Awesome! Thanks for the invite! I look forward to help maintaining and improving Prawn in whatever way I can. It's essential for Asciidoctor PDF and hopefully it will bring much deserved attention to this awesome family of libraries. Thanks again and I look forward to working with the group! |
A slightly modified version of #19.