Add testing with Ruby 2.6 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also changes the Travis CI config to include the same JRuby versions as pdf-core and prawn.
|
Whoops, just saw I accidentally removed Ruby 2.2 there. @pointlessone, do you want to keep Ruby 2.2 support in this gem unlike pdf-core and prawn? Then I can add it back of course! |
|
No, 2.2 must go. It's not supported upstream so we don't support it either. |
|
Ok, then I'll leave the PR as it is now. |
pointlessone
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the Travis CI config to include the same JRuby versions as pdf-core and prawn.