Actualize rubocop version and fix issues #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a16fb67.
|
UPD2: All those non actual since Ok, CI seems fine except for ruby 2.4 - can't handle Ruby 2.4 is EOLed a half-year ago I can try to fix it's required version or just removed it UPD: Fixed, looks pretty safe for me 6490ebc |
|
@pointlessone could you please take a look, I'm gladly receive any kind of feedback ) |
|
Any news? |
|
Thank you for your contribution. I have implemented a shared Rubocop config (among other things) and had to test it myself a bunch so I ended up not using your PR. |
|
@pointlessone Ok, fair enough, thanks for new release with ruby 3.0 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to fix as many issues as able, but feel free to mention code styles changed with maintainer team is not agree, I'm able to revert almost all of this changes without much troubles