Add IrcConnection.capEnd() function to avoid sending CAP END twice #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other than the correctness issue, this is needed to prevent a crash in bitlbee 3.4.2 when CAP END is sent after registration, which kiwiirc seems to trigger when it receives 900 followed by a 903 later. The crash itself is fixed in git versions of bitlbee, but it would be nice if kiwiirc worked fine with the last release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than the correctness issue, this is needed to prevent a crash in bitlbee 3.4.2 when CAP END is sent after registration, which kiwiirc seems to trigger when it receives 900 followed by a 903 later.
The crash itself is fixed in git versions of bitlbee, but it would be nice if kiwiirc worked fine with the last release.