Merge pull request #23 from aliscott/render_hash_dump

Properly render collections of Attributor::Hash when fields=true

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## next
 
-* Ensure we call `object.dump` in Renderer when dumping a Attributor::Hash if no subfields were selected.
+* Ensure we call `object.dump` in Renderer when dumping a Attributor::Hash or collection of Attributor::Hash if no subfields were selected.
 
 ## 3.1
 

lib/praxis-blueprints/renderer.rb

@@ -55,7 +55,14 @@ def render(object, fields, view=nil, context: Attributor::DEFAULT_ROOT_CONTEXT)
     end
 
     def _render(object, fields, view=nil, context: Attributor::DEFAULT_ROOT_CONTEXT)
-      return object if fields == true
+      if fields == true
+        return case object
+        when Attributor::Hash
+          object.dump
+        else
+          object
+        end
+      end
 
       notification_payload = {
         blueprint: object,

spec/praxis-blueprints/renderer_spec.rb

@@ -151,7 +151,7 @@
 
   end
 
-  context 'rendering collections of hashes' do
+  context 'rendering hashes' do
     let(:fields) do
       {
         id: true,
@@ -170,4 +170,27 @@
     its([:hash]) { should be_kind_of(Hash) }
   end
 
+  context 'rendering collections of hashes' do
+    let(:fields) do
+      {
+        id: true,
+        hash_collection: [true]
+      }
+    end
+
+    let(:data) { {id: 10, hash_collection: [{foo: 'bar'}]} }
+    let(:object) { SimpleHashCollection.load(data)}
+    let(:renderer) { Praxis::Renderer.new }
+
+    subject(:output) { renderer.render(object, fields) }
+
+    its([:id]) { should eq data[:id] }
+    its([:hash_collection]) { should eq data[:hash_collection] }
+    its([:hash_collection]) { should be_kind_of(Array) }
+
+    it 'renders the hashes' do
+      expect(output[:hash_collection].first).to be_kind_of(Hash)
+    end
+  end
+
 end

spec/support/spec_blueprints.rb

@@ -109,3 +109,11 @@ class SimpleHash  < Attributor::Model
     attribute :hash,  Hash
   end
 end
+
+
+class SimpleHashCollection < Attributor::Model
+  attributes do
+    attribute :id, Integer
+    attribute :hash_collection, Attributor::Collection.of(Hash)
+  end
+end