Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jellyfin 10.9 Support #146

Closed
prayag17 opened this issue May 14, 2024 · 16 comments
Closed

Jellyfin 10.9 Support #146

prayag17 opened this issue May 14, 2024 · 16 comments

Comments

@prayag17
Copy link
Owner

JellySkin won't work with 10.9 due to changes made by the jellyfin team and a lot of refactoring on their end. I have planned to release a patch for this by 1st week of june

@prayag17 prayag17 pinned this issue May 14, 2024
@wolflord212312
Copy link

Good to know, as I just got someone Telling me today that the web version wont show any of the MEdia i was like Huh (as i dont use web version i use the applications), After some digging i found that if i inspect element the stuff is there just for some reason not visable so disabled CSS Thx for the update Hope to see the patch thx!

@LordRofl
Copy link

Also for JellyFlix? :)

@prayag17
Copy link
Owner Author

JellyFlix will follow the release of JellySkin

@blunweon
Copy link

blunweon commented May 26, 2024

Not sure if this is the right place to share this but I found a temporary fix mentioned by someone on the Jellyfin-Skin-Manager repo that still allows us to use JellySkin.

By adding

.content-primary {
  margin-left: 260px;
}
.mainAnimatedPages.skinBody {
  height: 100vh;
}

to the end of the main CSS import line like so -

@import url("https://cdn.jsdelivr.net/npm/jellyskin@latest/dist/main.css");
.content-primary {
  margin-left: 260px;
}
.mainAnimatedPages.skinBody {
  height: 100vh;
}

Small caveat on mobile, which is what I see the changes; you get a weird formatting of the new Admin Dashboard pages.

@prayag17
Copy link
Owner Author

Already fixed the scroll issue

@blunweon
Copy link

Oh, thank you for the update. However, I am still facing that issue without the quick and dirty fix mentioned above.

This is my UI with the fix and following CSS:

@import url("https://cdn.jsdelivr.net/npm/jellyskin@latest/dist/main.css");
.content-primary {
  margin-left: 260px;
}
.mainAnimatedPages.skinBody {
  height: 100vh;
}
@import url("https://cdn.jsdelivr.net/npm/jellyskin@latest/dist/logo.css");
@import  url("https://cdn.jsdelivr.net/npm/jellyskin@latest/dist/addons/horizontalMyMedia.css");
@import url("https://cdn.jsdelivr.net/npm/jellyskin@latest/dist/addons/gradients/mauve.css");

image

This is without the fix and the following code

@import url("https://cdn.jsdelivr.net/npm/jellyskin@latest/dist/main.css");
@import url("https://cdn.jsdelivr.net/npm/jellyskin@latest/dist/logo.css");
@import  url("https://cdn.jsdelivr.net/npm/jellyskin@latest/dist/addons/horizontalMyMedia.css");
@import url("https://cdn.jsdelivr.net/npm/jellyskin@latest/dist/addons/gradients/mauve.css");

image
image

Let me know if this is the wrong place to be asking about this!

@prayag17
Copy link
Owner Author

Update is still not pushed to cdn as I am still working. This issue will be closed after 10.9 support is published

@prayag17
Copy link
Owner Author

JellySkin v12.5 is now published with Jellyfin 10.9 support

@neurekadev
Copy link

@prayag17 This is still an issue:

image

@LeviSnoot
Copy link

@prayag17 This is still an issue:

image

See #147

@prayag17
Copy link
Owner Author

Change @latest to @12.5.0 cdn takes sometime to update

@prayag17
Copy link
Owner Author

prayag17 commented May 31, 2024

@prayag17 This is still an issue:

image

See #147

Check my comment in that issue @LeviSnoot

@LeviSnoot
Copy link

I know, I was replying to @neurekadev haha

@neurekadev
Copy link

@prayag17 This is still an issue:
image

See #147

Change @latest to @12.5.0 cdn takes sometime to update

Thank you!

@FaNt4zMa
Copy link

FaNt4zMa commented Jun 9, 2024

Is it normal that the icons are back to default and not material design? It kinda bothers me and I'd like to know if they will come back? Thanks
image
image
Edit: Is the font back to default aswell? Or am I crazy?

@prayag17
Copy link
Owner Author

prayag17 commented Jun 9, 2024

Yep the icons are now set to default and I won't add back the font awesome icons as they were a pain to manage. If someone wants to take on the development of Jellyfin-Icons then contact me but I have no plan to maintain it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants