💥 remove overwrite option (never worked)

prazdevs · Mar 5, 2022 · b88713c · b88713c
1 parent 6d18bf7
commit b88713c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 30 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -40,12 +40,6 @@ export interface PersistedStateOptions {
    */
   paths?: Array<string>
 
-  /**
-   * Overwrite initial state (patch otherwise).
-   * @default false
-   */
-  overwrite?: boolean
-
   /**
    * Serializer to use
    */
@@ -89,7 +83,6 @@ export default function PiniaPersistState(context: PiniaPluginContext): void {
     storage = localStorage,
     key = store.$id,
     paths = null,
-    overwrite = false,
     beforeRestore = null,
     afterRestore = null,
     serializer = {
@@ -103,9 +96,7 @@ export default function PiniaPersistState(context: PiniaPluginContext): void {
   try {
     const fromStorage = storage.getItem(key)
     if (fromStorage) {
-      const storageState = serializer.deserialize(fromStorage)
-      if (overwrite) store.$state = storageState
-      else store.$patch(storageState)
+      store.$patch(serializer.deserialize(fromStorage))
     }
   } catch (_error) {}
 

diff --git a/tests/index.spec.ts b/tests/index.spec.ts
@@ -276,26 +276,6 @@ describe('w/ storage', () => {
   })
 })
 
-describe('w/ overwrite', () => {
-  const useStore = defineStore(key, {
-    state: () => ({ lorem: 'ipsum' }),
-    persist: { overwrite: true },
-  })
-
-  it('overwrites store from storage', async () => {
-    //* arrange
-    initializeLocalStorage(key, { lorem: 'dolor sit amet' })
-
-    //* act
-    await nextTick()
-    const store = useStore()
-
-    //* assert
-    expect(store.lorem).toEqual('dolor sit amet')
-    expect(localStorage.getItem).toHaveBeenCalledWith(key)
-  })
-})
-
 describe('w/ hooks', () => {
   const beforeRestore = vi.fn(ctx => {
     ctx.store.before = 'before'