Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to change default plugin options #26

Closed
wants to merge 2 commits into from
Closed

Provide a way to change default plugin options #26

wants to merge 2 commits into from

Conversation

lbagic
Copy link

@lbagic lbagic commented Feb 28, 2022

Change includes exposing a new "wrapper" function which takes plugin options and uses them as new defaults (I needed it to change storage but exposed a few other plugin options too).

No tests included.

@prazdevs
Copy link
Owner

prazdevs commented Mar 1, 2022

Hi, thanks for considering this, I wanted to provide a way to do so, and that sort of solves the problem. Could you open an issue, I'll try to merge it and add some tests. Might take some time as for now, I'm not really into coding...
I appreciate the contribution and will make my best to make it available asap

@prazdevs
Copy link
Owner

prazdevs commented Mar 2, 2022

Hi I added some tooling so that DX is better for everyone. You can rework your dev to pass the CI.
I'm still not settled yet on what options should be considered default/overridable.
storage, beforeRestore and afterRestore sound good for now. Once a serialize/deserialize is added, i also think they should be included.
overwrite will probably be deprecated/removed as it actually doesn't really work with Pinia.

@prazdevs
Copy link
Owner

prazdevs commented Mar 6, 2022

done in #39

@prazdevs prazdevs closed this Mar 6, 2022
@N0tExisting N0tExisting mentioned this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants