Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MULTIARCH-3441: Enable builds for s390x (#1) #2

Merged
merged 1 commit into from
May 24, 2023

Conversation

jschintag
Copy link

  • Update the .goreleaser.yaml to include s390x
  • Update the cross build for s390x
  • Link gcc to s390x-linux-gnu-gcc binary

On s390x go compiler seems to expect the gcc binary at s390x-linux-gnu-gcc binary. However on rhel it is not installed there.

- Update the .goreleaser.yaml to include s390x
- Update the cross build for s390x
- Link gcc to s390x-linux-gnu-gcc binary

On s390x go compiler seems to expect the gcc binary at
s390x-linux-gnu-gcc binary. However on rhel it is not installed there.

Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
Copy link
Owner

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prb112 prb112 merged commit 8c78814 into prb112:MULTIARCH-3440a May 24, 2023
prb112 pushed a commit that referenced this pull request May 24, 2023
- Update the .goreleaser.yaml to include s390x
- Update the cross build for s390x
- Link gcc to s390x-linux-gnu-gcc binary

On s390x go compiler seems to expect the gcc binary at
s390x-linux-gnu-gcc binary. However on rhel it is not installed there.

Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
@jschintag jschintag deleted the enable-s390x branch June 20, 2023 07:10
prb112 added a commit that referenced this pull request Sep 27, 2023
…sing dockerfile and add ppc64le build to Makefile (openshift#624)

* MULTIARCH-3440: refine multiarch support for test-unit and test-e2e using dockerfile and add ppc64le build to Makefile

- Update the .goreleaser.yaml to include ppc64le
- Update the Dockerfile to include wget and pigz dependency
- Update the Dockerfile to consider arch it's built on
- Update the util.sh to be arch agnostic
- Update the cross build for ppc64le

Signed-off-by: Paul Bastide <pbastide@redhat.com>

* MULTIARCH-3440: Update per review

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>

Co-authored-by: Jan Schintag <43986265+jschintag@users.noreply.github.com>

* MULTIARCH-3441: Enable builds for s390x (#1)

- Update the .goreleaser.yaml to include s390x
- Update the cross build for s390x
- Link gcc to s390x-linux-gnu-gcc binary

On s390x go compiler seems to expect the gcc binary at
s390x-linux-gnu-gcc binary. However on rhel it is not installed there.

Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>

* MULTIARCH-3441: Enable builds for s390x (#1) (#2)

- Update the .goreleaser.yaml to include s390x
- Update the cross build for s390x
- Link gcc to s390x-linux-gnu-gcc binary

On s390x go compiler seems to expect the gcc binary at
s390x-linux-gnu-gcc binary. However on rhel it is not installed there.

Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>

* MULTIARCH-3440: update the code to use go-containerregistry for all arches and add arm64

Signed-off-by: Paul Bastide <pbastide@redhat.com>

* MULTIARCH-3440: Adding cross-build for arm64

Signed-off-by: Paul Bastide <pbastide@redhat.com>

---------

Signed-off-by: Paul Bastide <pbastide@redhat.com>
Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
Co-authored-by: Jan Schintag <43986265+jschintag@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants