Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakpoint not hit and stepping in function not correct #260

Closed
prb28 opened this issue Mar 22, 2023 · 2 comments
Closed

Breakpoint not hit and stepping in function not correct #260

prb28 opened this issue Mar 22, 2023 · 2 comments
Labels
bug Something isn't working
Milestone
1.8.2

Comments

@prb28
Copy link
Owner

prb28 commented Mar 22, 2023 •
edited
Loading

The bigger problem is the handling of breakpoints. These are set incorrectly or not triggered at all.
If you start the project and end up in the debugger ("stopOnEntry": true) and then press F11 to continue to the InitSystem jump, the "function" from the startup.s file is not displayed, but a wrong position in the main.s file.
grafik

If you set a breakpoint in the files asset.s on the function AllocAssetMem, it is not triggered.

The problem does NOT exist with version 1.6, in which the code can be stepped through and debugged properly.
grafik

Description in #259
@prb28
Copy link
Owner Author

prb28 commented Mar 22, 2023 •
edited
Loading

@grahambates Can you please look at this issue ?

@prb28 prb28 added this to the 1.8.2 milestone Mar 22, 2023
@prb28 prb28 added the bug Something isn't working label Mar 22, 2023
@grahambates
Copy link
Contributor

Yeah sure. I can reproduce the issue. I'll have a go at fixing it tomorrow.

grahambates added a commit to grahambates/uae-dap that referenced this issue Mar 23, 2023
@grahambates
fix: sourcemap addresses incorrect
a6cb516 
`baseOffset` shouldn't be added to address.

refs: prb28/vscode-amiga-assembly#260
grahambates added a commit to grahambates/vscode-amiga-assembly that referenced this issue Mar 23, 2023
@grahambates
fix(prb28#260): Breakpoint not hit
c0b4cc0 
Upgrades to uae-dap@1.0.2 with fix to address calculation.
prb28 added a commit that referenced this issue Mar 23, 2023
@prb28
Merge pull request #261 from grahambates/uae-dap-1.0.2
2b1395b 
fix(#260): Breakpoint not hit
@prb28 prb28 closed this as completed Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.8.2
Development

No branches or pull requests
2 participants
@grahambates @prb28