Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working directory for emulator is invalid #28

Closed
pchalamet opened this issue Oct 18, 2018 · 3 comments
Closed

Working directory for emulator is invalid #28

pchalamet opened this issue Oct 18, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@pchalamet
Copy link
Contributor

Hi,
Working directory of emulator (fs-uae) is not set in the extension on launch - hence it default to the working directory of VS Code - which leads to errors on startup (both Windows and macOS). And I do not want to put fs-uae configuration into VSCode one.

I've done a patch to let user configure working directory:

            "buildWorkspace": true,
            "emulator": "d:\\tools\\amiga\\fs-uae.exe",
            "workingdir": "d:\\tools\\amiga\\fs-uae",

The patch is for review here: https://github.com/pchalamet/vscode-amiga-assembly/commit/1b22b2b1bca0b3336fb09ab3b70e1a2cfba10999

Let me know if you are ok for a PR. If you do not agree on "workingdir", let's provide a better name for that.

Thanks.

@prb28 prb28 added the enhancement New feature or request label Oct 18, 2018
@prb28
Copy link
Owner

prb28 commented Oct 18, 2018

Hi, thank you for this feature !
Yes, you are welcome to make a PR.
For the name what do you think about emulatorWorkingDir ? I think that workingdir may be confused with the workspace dir.
There is a modification to do in the package.json file, but I can do it after your request.

@pchalamet
Copy link
Contributor Author

Good. Doing the change right now and send the PR. I will let you then bump package version number on your side.
Thanks.

@pchalamet
Copy link
Contributor Author

PR on the way: #29

prb28 added a commit that referenced this issue Oct 18, 2018
Working directory for emulator is invalid (issue #28)
@prb28 prb28 added bug Something isn't working and removed enhancement New feature or request labels Oct 18, 2018
@prb28 prb28 closed this as completed Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants