Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dansabel #167

Closed
tykling opened this issue Jan 30, 2023 · 2 comments
Closed

Support dansabel #167

tykling opened this issue Jan 30, 2023 · 2 comments

Comments

@tykling
Copy link

tykling commented Jan 30, 2023

Hello :)

We use https://github.com/semaphor-dk/dansabel but it doesn't work on pre-commit.ci - it fails with the following error:
build of https://github.com/semaphor-dk/dansabel@0ce89b6009f628b1681a825519b683dc0f1a1392 for python@python3 exceeds tier max size 250MiB: 384.1MiB

Is this something I need to bring up with the authors of dansabel or is this an issue that needs to be fixed here? thanks! :)
@asottile
Copy link
Member

dansabel pulls in ansible (which is the entire collection of ansible tooling) -- it probably wants ansible-core

$ du -hs v*
59M	venvnew
424M	venvold

@tykling
Copy link
Author

tykling commented Jan 30, 2023

ah great 👍 I will speak to them, thank you! :)

@tykling tykling closed this as completed Jan 30, 2023
@tykling tykling mentioned this issue Jan 30, 2023
Closed
jokjr added a commit to semaphor-dk/dansabel that referenced this issue Jan 30, 2023
@jokjr
Depend on ansible-core instead of ansible
3643a44 
Fixes #18

I think @asottile is correct that we were a bit overeager with our dependency on `ansible`. See also pre-commit-ci/issues#167

Thanks @tykling :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asottile @tykling