Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit/action@v3.0.0 Depends on actions/cache@v3 which is using Node 16 which is now deprecated #189

Closed
bakerkj opened this issue Feb 5, 2024 · 4 comments
Closed

pre-commit/action@v3.0.0 Depends on actions/cache@v3 which is using Node 16 which is now deprecated #189

bakerkj opened this issue Feb 5, 2024 · 4 comments

Comments

@bakerkj
Copy link

bakerkj commented Feb 5, 2024

This is the error message:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

actions/cache@v4 has been released for Node 20 please see https://github.com/actions/cache/releases/tag/v4.0.0
along with the specific PR actions/cache#1284.

Thanks!
@asottile
Copy link
Member

asottile commented Feb 5, 2024

fwiw this is just a warning not an error. github will transparently use the new node version without issue

@asottile asottile closed this as completed Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Merged
@davidorme davidorme mentioned this issue Feb 6, 2024
Merged
5 tasks
@bakerkj
Copy link
Author

bakerkj commented Feb 6, 2024 •
edited

@asottile yes thanks.

It does still produce a warning which does cause noise in our builds. It would be nice to fix the dependency either way.

Thanks!

@asottile
Copy link
Member

asottile commented Feb 6, 2024

feel free to send a patch

SukiCZ added a commit to SukiCZ/action that referenced this issue Feb 6, 2024
@SukiCZ
Upgrade to action/cache@v4. Fixes: pre-commit#189
faf9769
SukiCZ added a commit to SukiCZ/action that referenced this issue Feb 6, 2024
@SukiCZ
Upgrade action/cache to v4. Fixes: pre-commit#189
0dbc303
asottile added a commit that referenced this issue Feb 7, 2024
@asottile
Merge pull request #190 from SukiCZ/upgrade-action/cache-v4
8e2deeb 
Upgrade action/cache to v4. Fixes: #189
@khaeru khaeru mentioned this issue Feb 9, 2024
Merged
3 tasks
@bakerkj
Copy link
Author

bakerkj commented Feb 9, 2024

Thanks for the fix!

@francois-rozet francois-rozet mentioned this issue Feb 15, 2024
Merged
copybara-service bot pushed a commit to GoogleCloudPlatform/gcpdiag that referenced this issue Mar 14, 2024
@ebenezergraham
Upgrade pre-commit/actions to v3.0.1
f4f4603 
pre-commit/action#189
https://github.com/pre-commit/action/releases/tag/v3.0.1

Bug: 328630225
Change-Id: Ib51d6249e99deb67e558b833e1b422a99aa2666b
GitOrigin-RevId: 71c7289
Unagi-zoso added a commit to Unagi-zoso/kupica that referenced this issue Apr 25, 2024
@Unagi-zoso
#33 Feat cache 라이브러리 버전업 (v3 -> v4)
9a4986d 
현재 버전3 에서 `test
Node.js 16 actions are deprecated` 이라는 경고가 여전히 떠서 최신 버전으로 업 시켰다.

ref)
[참고 자료](pre-commit/action#189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asottile @bakerkj