Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embedding cache steps by using @actions/cache #31

Merged
merged 2 commits into from Jun 13, 2020
Merged

embedding cache steps by using @actions/cache #31

merged 2 commits into from Jun 13, 2020

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Jun 8, 2020 •
edited

a proposal, feel free to close it.

There is no need to add cache steps as @actions/cache is released and github actions can use it to cache files instead of adding a extra step.

asottile
asottile reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good, this wasn't an option when it was originally written

please revert style changes and structure changes and run the pre-commit hooks (lol)

Makefile Outdated Show resolved Hide resolved
asottile
asottile reviewed Jun 11, 2020
View reviewed changes
cache.js Outdated Show resolved Hide resolved
asottile
asottile reviewed Jun 11, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
asottile
asottile approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 5c843d9 into pre-commit:master Jun 13, 2020
@mschwager mschwager mentioned this pull request Jun 23, 2020
Merged
@mxr mxr mentioned this pull request Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trim21 @asottile