.pyi files should be identified as python

[chadrik]

.pyi files are the basis for PEP 484 static type checking, and should be identified as python files.

[asottile]

I'm hesitant to classify them directly as python as they have quite different formatting style (for instance I wouldn't run flake8 on them). That said, they aren't classified at all yet. Would you be OK with them (for now) being classified as pyi and then perhaps in the future extend that to python?

[chadrik]

Wow, thanks for the fast response.

I'm working on adding stubs to attrs, which uses pre-commit to run black to reformat python files, but pre-commit will only feed files to black which identify marks as python (whew! still with me?).

I'm hesitant to classify them directly as python as they have quite different formatting style (for instance I wouldn't run flake8 on them).

black for one is smart enough to treat pyi files specially when reformatting them, but I understand your wariness.

Would you be OK with them (for now) being classified as pyi and then perhaps in the future extend that to python?

I have a solution that works for now, but I wanted to notify the authors of the various projects so that a better solution can be worked out. I'm going to go point this out over at black and let you all sort it out ;)

[asottile]

for pre-commit (once identify supports pyi) you can hook it up as follows:

    hooks:
    -   id: black
    -   id: black
         name: black (pyi)
         types: [pyi]

let me get pyis classified for ya though :)

[asottile]

here's the PR to classify pyi as... well... pyi for now :) #52

[asottile]

pyi is now classified as of v1.1.3

[chadrik]

thanks!

…

On Tue, Jul 10, 2018 at 10:05 PM Anthony Sottile ***@***.***> wrote: pyi is now classified as of v1.1.3 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#51 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD3E_ToAdRA3Kluy97W5EwBvFFwNnvxks5uFYe2gaJpZM4VKek_> .