Add a bunch more extensions #12
Conversation
identify/extensions.py
Outdated
| 'bat': {'text', 'batch'}, | ||
| 'bz2': {'binary', 'bzip2'}, | ||
| 'c': {'text', 'c'}, | ||
| 'cc': {'text', 'c++'}, | ||
| 'cfg': {'text', 'conf'}, |
There was a problem hiding this comment.
This is probably going to change the parsing of setup.cfg
There was a problem hiding this comment.
yeah, not sure what to do. obviously .conf/.cfg/.cnf represent tons of different file formats
maybe we should just omit it (or just have {'text'}) since you can't reliably assume anything based on the type?
There was a problem hiding this comment.
I was meaning towards omission as well (why I didn't fill out . txt). Maybe we just leave these as text and give higher priority to the named files?
identify/extensions.py
Outdated
| 'png': {'binary', 'image', 'png'}, | ||
| 'po': {'text', 'pofile'}, | ||
| 'pp': {'text', 'puppet'}, | ||
| 'proto': {'binary', 'proto'}, |
There was a problem hiding this comment.
Hmmm i thought these were text files
|
@asottile made filename matches take precedence over extension matches so that, for example, |
These come from cloning the 50 most starred GitHub repos and picking out extensions that seem like they should be added.