Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .resx to extensions.py #331

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Add .resx to extensions.py #331

merged 1 commit into from
Oct 3, 2022

Conversation

CSymes
Copy link
Contributor

@CSymes CSymes commented Sep 30, 2022

.NET uses .resx files to container XML resource descriptors for various resources (e.g. localisation strings, and images) and the IDE manages autogeneration of the XML to describe the contents.
Since it's usually autogenerated, it would be useful to be able to easily target these for exclusion with pre-commit.

I don't know what you consider a canonical source regarding file formats, seeing as anyone can use any format for whatever they choose, but this extension's definition is generally well documented online.

Could be worth adding a contributing.md to your project so it's easy for people to see what you expect when sending a PR too :)

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 3c8710d into pre-commit:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants