Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements-txt-fixer does not handle multiline dependencies #465

Closed
aniketbhatnagar opened this issue Apr 26, 2020 · 2 comments · Fixed by #469
Closed

requirements-txt-fixer does not handle multiline dependencies #465

aniketbhatnagar opened this issue Apr 26, 2020 · 2 comments · Fixed by #469
Labels
enhancement good-first-issue

Comments

@aniketbhatnagar
Copy link
Contributor

Given:

distlib==0.3.0 \
    --hash=sha256:2e166e231a26b36d6dfe35a48c4464346620f8645ed0ace01ee31822b288de21
appdirs==1.4.3 \
    --hash=sha256:9e5896d1372858f8dd3344faf4e5014d21849c756c8d5701f78f8a103b372d92 \
    --hash=sha256:d8b24664561d0d34ddfaec54636d502d7cea6e29c3eaf68f3df6180863e2166e
filelock==3.0.12 \
    --hash=sha256:18d82244ee114f543149c66a6e0c14e9c4f8a1044b5cdaadd0f82159d6a6ff59 \
    --hash=sha256:929b7d63ec5b7d6b71b0fa5ac14e030b3f70b75747cef1b10da9b879fef15836

requirements-txt-fixer will move all --hash lines on top of the file.
@asottile
Copy link
Member

indeed -- would you be interested in sending a patch?

@aniketbhatnagar aniketbhatnagar mentioned this issue May 7, 2020
Merged
@aniketbhatnagar
Copy link
Contributor Author

alright.. here is an attempt - #469

asottile added a commit that referenced this issue May 8, 2020
@asottile
Merge pull request #469 from aniketbhatnagar/465-Handle-Hash
e56e5bb 
[#465] Handled multiline dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good-first-issue
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#465] Handled multiline dependencies aniketbhatnagar/pre-commit-hooks
2 participants
@aniketbhatnagar @asottile