Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group hooks by type #341

Closed
brettcannon opened this issue May 14, 2020 · 4 comments · Fixed by #435
Closed

Group hooks by type #341

brettcannon opened this issue May 14, 2020 · 4 comments · Fixed by #435

Comments

@brettcannon
Copy link

It would be really handy to have the hooks grouped by what it specified in the types field in the JSON data. That way if I'm looking to see what hooks apply to Python I can look in that section. I would assume this would be its own <h2> section after the current by-repository list.
@asottile
Copy link
Member

I think some sort of search would be better than grouping, but I'm not sure what that would look like 🤔

@brettcannon
Copy link
Author

Maybe a filter drop-down at the top? It lists all the known types and you select one and it filters the lists down to just type matches?

@asottile
Copy link
Member

yeah that could work -- the data is available in json so it could use that to build a search

@paulhfischer paulhfischer mentioned this issue Dec 19, 2020
Merged
@brettcannon
Copy link
Author

Thanks so much to everyone who helped make this happen!

I've now submitted a couple PRs to fill out the types fields on some hooks to fill out the list a bit more. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added id and type filter for hooks
2 participants
@brettcannon @asottile